Closed Bug 1720534 Opened 3 years ago Closed 3 years ago

Clean up styles in the Bookmarks Menu Button menupopups on Windows 7 and 10

Categories

(Firefox :: Theme, defect)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image image.png

The Bookmarks Menu Button menupopup has labels that aren't aligned properly - they have the menuitem-iconic class on them, which indents the labels for icons that aren't there. They also inherit some Windows-specific styles from menu.css which break alignment a bit.

The screenshot tries to illustrate what I'm seeing on Windows 7. Similar issues exist on Windows 10.

Attachment #9231203 - Attachment description: Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r?mhowell → Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r?mhowell!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc4e5ea0c986
Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1723754
No longer regressions: 1723754
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: