1721563 - [Wayland] Pasting from external application freezes browser

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

STR:

1. Start with MOZ_ENABLE_WAYLAND=1 on Ubuntu 21.04.
2. Copy plain text from gedit and paste into location bar.

Browser window becomes unresponsive and main process consumes 100% of a CPU core.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=da1412413022e9f41073122b340e6f8d79091bb9&tochange=35d406f57982d5cf0a8d3f73421903d99c49ca8b

Regressed by Bug 1717476.

Comment 1

[Francois Guerraz]

Confirmed regression on Arch Gnome/Wayland too.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Interesting, will look at it.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Backtrace

I was going to file this... This is the stack trace on the main thread fwiw.

Comment 5

[David Gow]

FYI: This also appears to happen on KDE/KWin 5.22.3 on openSUSE Tumbleweed, so it's not specific to GNOME.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Yes, from some reason the reading from fd is blocked. Interesting is that when switched to Async mode the read works. Also it's blocked for chrome process only, content works ok.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1721563 [Wayland] Flush wl_display connection before reading clipboard data, r?emilio

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1721563 [Wayland] Limit time of reading clipboard data, r?emilio

We're reading clipboard data from fd in non-blocking mode and repeat when data ate not ready.

Modify reading from fd to make sure we don't wait endlessly:

• sleep 20 ms after unsuccessful before next attempt
• limit maximal reading time to 0.5 sec

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef1b2cfdf17b
[Wayland] Flush wl_display connection before reading clipboard data, r=emilio

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c6a58288b99
[Wayland] Limit time of reading clipboard data, r=emilio

Comment 16

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ef1b2cfdf17b
https://hg.mozilla.org/mozilla-central/rev/2c6a58288b99

Comment 17

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 92.0a1 (2021-07-21) under Ubuntu 20.04 Wayland by following the STR from Comment 0.

The issue is no longer reproducible on Firefox 92.0 on the same system.