1721821 - LDAP display result with property "Don't return more than" does not work in some cases

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1. Add an LDAP directory
2. Set "Don't return more than" property, but not at 0
3. Do an LDAP search which is supposed to return a lot of results

Actual results:

If the value of the property "Don't return more than" is less than the number of results, the popup displaying the results is not displayed.

I tested with Wireshark to verify that I was getting: "sizeLimitExceeded"

Expected results:

The popup with the results is displayed.

Comment 1

[John Bieling (:TbSync)]

Is this a regression added in TB91 or also present in Tb78?

Comment 2

[adrien.rybarczyk]

Regression in TB91.
The popup with the results is displayed in 78.

Comment 3

[Ping Chen [:rnons] (away)]

Thanks for reporting, can you post a screenshot of the popup you are talking about? I don't remember seeing one. I tested in 78 just now, set "Don't return more than" to 10, did a search and 10 results are returned. Didn't see any popup and don't know what the popup is supposed to do.

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1721821 - Fix ldap autocomplete when server returns sizeLimitExceeded. r=darktrojan

sizeLimitExceeded was incorrectly treated as failure, so the autocomplete popup was not shown.

Depends on D120685.

Comment 5

[Ping Chen [:rnons] (away)]

can you post a screenshot of the popup you are talking about?

Never mind, I see it's about the autocomplete in compose window now. Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/902669b643c7
Fix ldap autocomplete when server returns sizeLimitExceeded. r=darktrojan

Comment 7

[Ping Chen [:rnons] (away)]

Comment on attachment 9232764 [details]
Bug 1721821 - Fix ldap autocomplete when server returns sizeLimitExceeded. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: LDAP autocomplete doesn't work if server returns sizeLimitExceeded
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9232764 [details]
Bug 1721821 - Fix ldap autocomplete when server returns sizeLimitExceeded. r=darktrojan

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/a904779fec05