1721828 - LDAP search filter does not work

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1. Add an LDAP directory
2. Set a Search Filter
3. Do an LDAP search

Actual results:

The filter is not applied.
I checked with wireshark in the Filter part.

The bug is not present in TB78. It seems to be a regression from TB91.

Expected results:

The filter is applied.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1721828 - Use configured search filter in LDAPDirectoryQuery.jsm. r=darktrojan

If nsILDAPURL.filter is not empty and not default, merge it with user query filter and send to the server.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/57250bb070f5
Use configured search filter in LDAPDirectoryQuery.jsm. r=darktrojan

Comment 3

[Ping Chen [:rnons] (away)]

Comment on attachment 9232755 [details]
Bug 1721828 - Use configured search filter in LDAPDirectoryQuery.jsm. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: Configured ldap search filter is not used.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9232755 [details]
Bug 1721828 - Use configured search filter in LDAPDirectoryQuery.jsm. r=darktrojan

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/6c51b93b0374