172203 - Use GTK2 setting to determine if textfields should be selected when tabbed to

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Aaron Leventhal]

In bug 28583, we are implementing select text field contents on keyboard focus.

GTK2 has an OS-wide setting that should be exposed through
widget/src/gtk2/nsLookAndFeel.cpp
at case eMetric_SelectTextfieldsOnKeyFocus:

Akkana, on IRC you mentioned something about ~/.gtkrc-2.0
gtk-entry-select-on-focus = 0

Comment 1

[Christopher Blizzard (:blizzard)]

I need to figure out how to get that setting - I don't think it's that hard to
figure out.

Comment 2

[Anders Carlsson]

It's a gtksetting, just use

settings = gtk_settings_get_default ();
gboolean bool;

g_object_get (settings, "settings_name", &boolean, NULL);

You can also monitor any changes to the setting by connecting to the
"notify::settings_name" signal of the GtkSettings object.

Comment 3

[Christopher Blizzard (:blizzard)]

Great, thanks.

Comment 4

[Aaron Leventhal]

The dependency bug 28583 is ready for sr=

Comment 5

[Anders Carlsson]

I can make a patch for this if you want blizzard...

Comment 6

[Christopher Blizzard (:blizzard)]

Sure, go right ahead!

Comment 7

[Christopher Blizzard (:blizzard)]

-> [e-mail]

Comment 8

[Anders Carlsson]

Attachment: Patch

This patch seems to work for me, although text in the bookmark name entry will
always be selected. That seems to be an issue with the bookmark dialog.

Comment 9

[Ilya Konstantinov]

Comment on attachment 104133 [details] [diff] [review]
Patch

From 2002 and it hasn't bitrot a bit! Let's get this one checked in.

Comment 10

[Brian Ryner (not reading)]

Comment on attachment 104133 [details] [diff] [review]
Patch

Hm, is all the ref/sink/unref stuff really needed?  Blizzard would know better
than me.  One nit: space after "if".

Comment 11

[Christopher Blizzard (:blizzard)]

I would expect that stuff to be required, yeah.

Comment 12

[sairuh (rarely reading bugmail)]

the patch has been r/sr'd --but I'm not sure how much of it has bit-rotted.
nominating for the 1.8a5 train, in case it's can easily be cleaned up (if
needed) and checked in.

Comment 13

[Asa Dotzler [:asa]]

Let's try for 1.8a6.

Comment 14

[Asa Dotzler [:asa]]

this would be nice to have but it's not a blocker. 

Comment 15

[Ginn Chen]

Attachment: patch (updated)

The patch is quite old, so I redo a patch without any change.
It works well.
Shall we commit it?

Comment 16

[Aaron Leventhal]

Looking at the patch I don't see any reason why we shouldn't commit it still.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Not a blocker, but please do check in once the tree opens for 1.8b2.

Comment 18

[Ginn Chen]

Checking in nsLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsLookAndFeel.cpp,v  <--  nsLookAndFeel.cpp
new revision: 1.22; previous revision: 1.21
done