1722090 - Move httpd.js and WebSocket specific tests that use RemoteAgent.listen() to Wdspec tests

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Any test that is using RemoteAgent.listen() and also stops the Remote Agent from listening has to be moved to a Wdspec test. Once done we want to extend the lifetime of the Remote Agent to the full Firefox session (bug 1717899).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tests that we currently have in CDP related browser chrome tests are these:
https://searchfox.org/mozilla-central/search?q=RemoteAgent.listen%28

Some of these should already be covered by existing wdspec tests and the rest we should be able to move over here:
https://searchfox.org/mozilla-central/source/testing/web-platform/mozilla/tests/webdriver/bidi/websocket_upgrade.py

Comment 2

[Julian Descottes [:jdescottes]]

Note that tests which exercise calling RemoteAgent.listen on something else than localhost would be blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1754364

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Julian Descottes [:jdescottes] from comment #2)

Note that tests which exercise calling RemoteAgent.listen on something else than localhost would be blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1754364

As discussed on Elements, we will remove the ability to start the RemoteAgent on non-localhost in Bug 1759998, and at the same time, we will remove the related tests. All the remaining tests should then be moved to wdspec tests as suggested above.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug blocks bug 1717899 which is required to get WebDriver Bidi enabled on the release channels. As such bringing it into our milestone.

What needs to be done for this bug? Here an overview of the currently remaining tests that need to be moved or deleted:

remote/cdp/test/browser/component/browser_agent_webdriver_bidi.js

This module contains just a single test for the WebDriverBiDiActivePort file. This is already covered by wdspec tests and as such the file can be removed.

remote/cdp/test/browser/browser_httpd.js

There is only one test contained for the /json/version end-point. This test can remain as is and needs to be updated with bug 1717899.

remote/cdp/test/browser/component/browser_agent.js

debuggerAddress

Only checks for the debuggerAddress property on the RemoteAgent. This test can remain as is and needs to be updated with bug 1717899.

listening

Checks the listening property. This test can remain as is and needs to be updated with bug 1717899.

remoteListeningNotification

Checks for the remote-listening observer notification which the Remote Agent sends out when being enabled. This test can no longer be kept given that we cannot catch that notification when the Remote Agent is enabled in final-ui-startup. It can be removed as part of bug 1717899. A test needs to be written to verify that the cue (robot icon and striped location bar) has been set correctly (bug 1672366).

remoteDevToolsActivePortFile

Tests for the existence of the DevToolsActivePort file. I'll move this to a Mozilla wdspec test.

listenTakesString

Needs to be removed with bug with bug 1717899.

listenNonURL

Needs to be removed with bug with bug 1717899.

listenRestrictedToLoopbackDevice

Needs to be removed with bug with bug 1717899.

test_close

Needs to be removed with bug with bug 1717899.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1722090 - [wdspec] Reorganize Chrome DevTools Protocol tests.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1722090 - [remote] Move useful browser chrome tests for Remote Agent to wdspec.

Depends on D144212

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcb8036f32da
[wdspec] Reorganize Chrome DevTools Protocol tests. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f57cc4eec01a
[remote] Move useful browser chrome tests for Remote Agent to wdspec. r=webdriver-reviewers,jdescottes

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dcb8036f32da
https://hg.mozilla.org/mozilla-central/rev/f57cc4eec01a