1765731 - Cleanup outdated test_origin_header_allowed_when_bidi_disabled

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Julian Descottes [:jdescottes]]

The test at https://searchfox.org/mozilla-central/rev/6f6cf2810742d32454251afdb8e632c27999bea7/testing/web-platform/mozilla/tests/webdriver/new_session/debugger_address.py#88 should have been updated or removed after Bug 1750689 landed.

At the ery least it should have started to fail: the test was checking that when BiDi was disabled we would not check the origin header. This escape hatch was removed in Bug 1750689 when we added a way to specify custom host headers.

But the test still seems to pass so it's very likely that it's not testing what we expect and should be removed, after understanding which code path it really asserts.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, it didn't start to fail because we were using the /json/list endpoint which is not registered as a WebSocket handler.

Removing this test will actually be helpful for bug 1722090 so we do not have the mess with sticky Firefox preferences.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1765731 - [wdspec] Remove outdated test_origin_header_allowed_when_bidi_disabled test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b264e879ee96
[wdspec] Remove outdated test_origin_header_allowed_when_bidi_disabled test. r=webdriver-reviewers,jdescottes

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b264e879ee96