Accesskeys for buttons in Compact Folder dialog are not applied
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird_esr91 fixed, thunderbird88 unaffected, thunderbird89 unaffected, thunderbird90 unaffected, thunderbird91 fixed, thunderbird92 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird_esr91 | --- | fixed |
| thunderbird88 | --- | unaffected |
| thunderbird89 | --- | unaffected |
| thunderbird90 | --- | unaffected |
| thunderbird91 | --- | fixed |
| thunderbird92 | --- | fixed |
People
(Reporter: aryx, Assigned: thomas8)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.22 KB,
patch
|
Paenglab
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Thunderbird 92.0a1 20210726104616 on Windows 8.1, should also affect 91.0 betas.
Bug 1678856 also added accesskeys for the buttons in the revamped Compact Folder dialog but didn't add them to the data-l10n-attrs of the <dialog>, hence the access keys are neither visually shown nor are they working.
|
||
Comment 1•4 years ago
|
||
Thomas, can you pick this up for alex?
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
This fixes it.
Thanks Sebastian for the pointer!
|
|
Assignee | |
Comment 4•4 years ago
|
||
Comment on attachment 9233376 [details] [diff] [review]
1722408_compactDialogFixAccessKeys.diff
Straightforward one-liner...
(Alex is on PTO)
|
|
Assignee | |
Comment 5•4 years ago
|
||
Changed the reviewer in the commit message to r=Paenglab
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9233382 [details] [diff] [review]
1722408_compactDialogFixAccessKeys.diff
Thanks, this works.
|
|
Assignee | |
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d3849f5e9222
Fix access keys of Compact Folders Dialog. r=Paenglab
|
||
Updated•4 years ago
|
|
||
Comment 8•4 years ago
|
||
Regression and "91 affected" indicates that this should be uplifted.
|
|
Assignee | |
Comment 9•4 years ago
|
||
Comment on attachment 9233382 [details] [diff] [review]
1722408_compactDialogFixAccessKeys.diff
[Approval Request Comment]
Regression caused by (bug #): 1678856
User impact if declined: No access keys in compact folder dialog
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low - access key strings were already available, but not internally enabled.
|
|
||
Comment 10•4 years ago
|
||
Comment on attachment 9233382 [details] [diff] [review]
1722408_compactDialogFixAccessKeys.diff
[Triage Comment]
Approved for beta
|
||
Comment 11•4 years ago
•
|
||
| bugherder uplift | ||
Thunderbird 91.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/64e2929a7728
|
|
||
Comment 12•4 years ago
|
||
The flags appear to be wrong here. This is fixed in 91 and 91 ESR is hence not affected.
|
|
Assignee | |
Comment 13•4 years ago
|
||
(In reply to Uplift Request from comment #12)
The flags appear to be wrong here. This is fixed in 91 and 91 ESR is hence not affected.
Sure, thanks!
|
|
||
Comment 14•4 years ago
|
||
Background: We have queries that detect missed uplifts and this bug showed up as one of them due to the incorrect status.
Description
•