1722480 - [Wayland] Mostly unresponsive when starting with Light/Dark theme that is opposite system theme

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Kestrel]

STR:

1. Start with MOZ_ENABLE_WAYLAND=1 on Ubuntu 21.04 with default Yaru system theme.
2. Enable Dark theme in Firefox and restart.

Main process uses 100% CPU core and interface is laggy and sluggish about 50% of the time. Does not happen with Wayland disabled or using Light/Dark theme that matches system, for example Dark theme with Yaru-dark.

Starting with matching theme and then changing it at runtime causes some popups to stop appearing (eg addon installation).

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8fe101d17fe726e10a9a840e5e12ac95f0e48ae7&tochange=9ac290ec5884fd52bb6c16e9794da5b42f211cbb

Regressed by Bug 1718755.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Can you take a profile of it? Also does it happen with X11/xwayland?

Comment 2

[Kestrel]

The interface is extremely slow and too unresponsive for capturing a profile, I can stop the capture but it gets stuck loading the resulting tab. It does not happen with X11/xwayland.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ok, thanks, I'll try to reproduce this.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722480 - Ensure nsLookAndFeel::EnsureInit doesn't trigger any reentrant invalidation. r=stransky

RestoreSystemTheme() can trigger gtk theme name changes which can
trigger invalidations again. The other theme changes
(WithAltThemeConfigured and MatchFirefoxThemeIfNeeded) already did this
correctly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec24ea99da3f
Ensure nsLookAndFeel::EnsureInit doesn't trigger any reentrant invalidation. r=stransky

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ec24ea99da3f