172254 - [Cust] allow users to drop items anywhere on the customize sheet

Status: NEW

(Toolkit :: Toolbars and Toolbar Customization, enhancement)

Description

[Darren Salt]

It would be useful to be able to drop the object anywhere in the window, rather
than in only the palette itself. This can be implemented by moving the ondragover
and ondragdrop attributes from palette-box to main-box in customizeToolbar.xul.
(Alternatively, the palette could be given a visible border.)

Comment 1

[Asa Dotzler [:asa]]

->hewitt. 

Comment 2

[Asa Dotzler [:asa]]

updating summary.

Comment 3

[Chu Alan "sprite"]

Attachment: it seems like the bug is fixed with some simple move of code only

it seems like the bug is fixed with some simple move of code only

Comment 4

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 5

[miahz]

Attachment: the alternative - give the palette a visible border

simple theme fix.  adds border to inner palette area.  border style copied from
similar elements in the theme, so it should look uniform.

Comment 6

[miahz]

Attachment: updated patch diff'ed off latest nightly

(i'm using Gerv's Patch Maker script, diff'ing from the chrome dir.  i don't
know about all that cvs hoopla)

Comment 7

[miahz]

The theme fix is simple, and should get into 1.0.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Not a "blocker"

Comment 9

[miahz]

Attachment: patch: The zing it's been missing.

Updated to new source.	Styled palette with "-moz-appearance: listbox;" which
gives it an inset border and a white background, which, in my opinion, makes it
look great.  Copied the styles from mozapps/richview and global/listbox.  Also
removed old border since Customize is now a real window - bordering should be
handled by OS.

Comment 10

[miahz]

Comment on attachment 162840 [details] [diff] [review]
patch: The zing it's been missing.

Another polish patch, Kevin.  Cleans up the Customize palette.	How's it look?

Comment 11

[Kevin Gerich]

Comment on attachment 162840 [details] [diff] [review]
patch: The zing it's been missing.

Having the palette-box scrollbar just hang out in the middle of the window is
odd. But I don't like the listbox look. It should probably have the same border
that a groupbox does. But shouldn't the latest patch be moved to the spit &
polish bug? The first patch that was submitted looks like it solves the
reporter's issue. I don't think it should have been obsoleted.

Comment 12

[miahz]

Comment on attachment 162840 [details] [diff] [review]
patch: The zing it's been missing.

Ok, back to just the border.  Same as my initial patch.  Just what this bug was
requesting, no more.

Comment 13

[miahz]

Comment on attachment 142044 [details] [diff] [review]
updated patch diff'ed off latest nightly

Kevin, how about the original border-only patch?  I'll see what folks think
about the listbox style in the polish bug.

Comment 14

[Phil Ringnalda (:philor)]

Attachment: Return of drop-anywhere, v.1

Unrotting of the original patch.

I'm not completely sure about the UI of being able to drop a toolbar button on the "Done" button of a dialog, to have it go back into the palette, but it is closer to how I see people wanting to use drag-n-drop page layout programs, just throwing things they don't want off to the side rather than deleting them, and it certainly should get a better hearing than a couple of review requests to people who had both already left at the time.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 248207 [details] [diff] [review]
Return of drop-anywhere, v.1

Yeah, I'd get behind this. Lazier target seeking == more better, IMO.

I'd go further, though, and say that a drag off the toolbar just nukes that item.

Also, it would be nice to focus the removed item in the palette, so that users can easily replace it if they decide they want it back right after removing it.

Users can be fickle like that.

Comment 16

[Phil Ringnalda (:philor)]

Attachment: Unrotted

Rotted myself, I did.

Comment 17

[Phil Ringnalda (:philor)]

(In reply to comment #15)
> a drag off the toolbar just nukes that item.

Filed bug 370869, though since I use illegal drops as cancel, I'm ambivalent.

> Also, it would be nice to focus the removed item

Filed bug 370871, assuming you mean scroll into view (or, morph it if you think we should add visible focus rings).

Comment 18

[Asaf Romano (gone)]

Comment on attachment 255660 [details] [diff] [review]
Unrotted

http://lxr.mozilla.org/seamonkey/source/browser/base/content/customizeToolbarSheet.xul#84

Comment 19

[Phil Ringnalda (:philor)]

Sigh.