1722652 - Cleanup bindgen build setup

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1722652 - Setup bindgen flags for servo similarly to cranelift and neqo.

While the use of toml allows the flags to be separated, the split is
done via some shell shenanigans anyways, and servo's build.rs can
handle the same just fine.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1722652 - Reduce the number of flags passed to bindgen.

Originally, we only were using bindgen for stylo, and we also went a bit
overkill by including a lot of extra CFLAGS in there, which end up
being unnecessary. So we now only pass a more minimal set of flags, and
add some extra CFLAGS in cases where they are necessary.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acd2d4c44c5f
Setup bindgen flags for servo similarly to cranelift and neqo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/84ce7fe0ebe6
Reduce the number of flags passed to bindgen. r=firefox-build-system-reviewers,necko-reviewers,andi,dragana

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/acd2d4c44c5f
https://hg.mozilla.org/mozilla-central/rev/84ce7fe0ebe6

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1722652 - Bump the required version of system pixman.

Cairo uses PIXMAN_rgba_float/PIXMAN_rgb_float, which were added in
pixman 0.36.0.

Comment 6

[Phabricator Automation]

Comment on attachment 9234333 [details]
Bug 1722652 - Bump the required version of system pixman.

Revision D121570 was moved to bug 1723389. Setting attachment 9234333 [details] to obsolete.