1724278 - firefox nightly fails to compile with --enable-system-nss{nspr} with: ../include/mozilla/ResultExtensions.h:15:10: fatal error: 'prtypes.h' file not found

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[tt_1]

Attachment: aarch64-failes-prtypes-header.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

I tried to compile latest firefox from git on aarch64-unknown-linux-gnu

Actual results:

I got some errors complaining about a missing header, I believe it's from nspr:

3:33.03 [gecko-profiler 0.1.0] /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox_build/dist/include/mozilla/ResultExtensions.h:15:10: fatal error: 'prtypes.h' file not found
3:33.06 [gecko-profiler 0.1.0] /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox_build/dist/include/mozilla/ResultExtensions.h:15:10: fatal error: 'prtypes.h' file not found, err: true
3:33.10 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox_build/dist/include/mozilla/ResultExtensions.h:15:10: fatal error: 'prtypes.h' file not found
3:33.11 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox_build/dist/include/mozilla/ResultExtensions.h:15:10: fatal error: 'prtypes.h' file not found, err: true

Expected results:

I expect the compile to pass smoothly.

my crypto libs are =nspr-4.32 and =nss-3.69

there was a similar error related to the use of system-pixman, solved in https://bugzilla.mozilla.org/show_bug.cgi?id=1723389 , maybe it has a similar reason?

the compressed build log is attached

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Gecko Profiler' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The error is in mfbt: is in https://searchfox.org/mozilla-central/source/mfbt/ResultExtensions.h#15
Unfortunately the log is not very clear about what the chain of #includes is.

Forwarding bug to mfbt.

And NI: glandium, you fixed similar bug 1723389, could you please have a look at this? TIA

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1724278 - Fix --with-system-nspr build after bug 1722652

Comment 4

[tt_1]

the patch fixed the issue for me, thank you

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1722652

Comment 6

[tt_1]

did you forgot to push it to the nightly branch?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b055e7ad584
Fix --with-system-nspr build after bug 1722652 r=firefox-build-system-reviewers,mhentges

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 9235015 [details]
Bug 1724278 - Fix --with-system-nspr build after bug 1722652

Beta/Release Uplift Approval Request

• User impact if declined: Build failure in some setups
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB
• String changes made/needed: N/A

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8b055e7ad584

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235015 [details]
Bug 1724278 - Fix --with-system-nspr build after bug 1722652

Approved for 92.0b2.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6e04d192a6d9