Closed
Bug 172288
Opened 22 years ago
Closed 16 years ago
stop distributing xbl form controls (forms.jar)
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: bryner, Assigned: bryner)
References
Details
Attachments
(2 files, 1 obsolete file)
11.42 KB,
patch
|
Details | Diff | Splinter Review | |
950 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Since we're not going to turn on XBL form controls anytime soon, we should stop
packaging forms.jar in the installer builds.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Created http://bugscape.mcom.com/show_bug.cgi?id=20723 for the changes to the
Netscape installer files.
Comment 3•22 years ago
|
||
r=blake
Comment 4•22 years ago
|
||
Comment on attachment 103499 [details] [diff] [review]
patch
[Checkin: Comment 5]
r=me on the idea of not packaging XBL Form Controls. I don't by any means know
the ins and outs of packaging, but I presume that is what blake reviewed, so I
think you are covered.
Assignee | ||
Comment 5•22 years ago
|
||
checked into the trunk.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 6•22 years ago
|
||
hm, shouldn't the GUI for the xbl-preference also be removed then? (in the debug
panel)
Comment 7•22 years ago
|
||
Comment 8•22 years ago
|
||
This backout caused the default Mozilla to switch from classic to modern.
I checked this repeatedly to make sure it was the cause.
Assignee | ||
Comment 9•22 years ago
|
||
mkaply, are you seeing that on an existing profile or a new profile? Installing
over an existing build?
Comment 10•22 years ago
|
||
Any time you create a new profile, you have this problem.
You also see modern for all the profile manager stuff now.
Comment 11•22 years ago
|
||
Please reopen, cleanup is not complete. The preference itself should also be reset
(or ignored) as Mozilla now tries to use XBL forms, when enable, but due to the
missing forms.jar everything (such as Debug/Viewer Demos/#8 Forms) becomes a mess.
Comment 12•22 years ago
|
||
I am going to reopen this.
Alfred is correct.
You can't just remove the jar.
You need to remove the preference from the dialog and #if 0 the code in
CSSFrameConstructor and nsChromeRegistry so noone accidentally does this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•19 years ago
|
Assignee: bryner → nobody
Status: REOPENED → NEW
QA Contact: tpreston → layout.form-controls
Updated•18 years ago
|
Attachment #103499 -
Attachment description: patch → patch
[Checkin: Comment 5]
Comment 13•18 years ago
|
||
It seems <forms.jar> is (still) not packaged with Trunk Firefox/SeaMonkey/Thunderbird.
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070315 SeaMonkey/1.5a] (nightly) (W2Ksp4)
But SeaMonkey still has that debug UI entry.
Comment 14•16 years ago
|
||
Fixed by bug 412490.
Status: NEW → RESOLVED
Closed: 22 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Updated•16 years ago
|
Attachment #105550 -
Attachment description: Removing GUI for the xbl-preference → Removing GUI for the xbl-preference
[Moved to bug 412490]
Attachment #105550 -
Attachment is obsolete: true
Comment 15•16 years ago
|
||
(In reply to comment #12)
Ftr, CSSFrameConstructor part was removed by bug 473390.
Comment 16•16 years ago
|
||
Attachment #370216 -
Flags: superreview?(roc)
Attachment #370216 -
Flags: review?(roc)
Attachment #370216 -
Flags: superreview?(roc)
Attachment #370216 -
Flags: superreview+
Attachment #370216 -
Flags: review?(roc)
Attachment #370216 -
Flags: review+
Comment 17•16 years ago
|
||
Comment on attachment 370216 [details] [diff] [review]
(Cv1) all.js: Remove obsolete preference
[Checkin: Comment 17]
http://hg.mozilla.org/mozilla-central/rev/5979cfc7ead5
Attachment #370216 -
Attachment description: (Cv1) all.js: Remove obsolete preference → (Cv1) all.js: Remove obsolete preference
[Checkin: Comment 17]
Updated•16 years ago
|
Assignee: nobody → bryner
You need to log in
before you can comment on or make changes to this bug.
Description
•