172288 - stop distributing xbl form controls (forms.jar)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Brian Ryner (not reading)]

Since we're not going to turn on XBL form controls anytime soon, we should stop
packaging forms.jar in the installer builds.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch [Checkin: Comment 5]

Comment 2

[Brian Ryner (not reading)]

Created http://bugscape.mcom.com/show_bug.cgi?id=20723 for the changes to the
Netscape installer files.

Comment 3

[Blake Ross]

r=blake

Comment 4

[John Keiser (jkeiser)]

Comment on attachment 103499 [details] [diff] [review]
patch
[Checkin: Comment 5]

r=me on the idea of not packaging XBL Form Controls.  I don't by any means know
the ins and outs of packaging, but I presume that is what blake reviewed, so I
think you are covered.

Comment 5

[Brian Ryner (not reading)]

checked into the trunk.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, shouldn't the GUI for the xbl-preference also be removed then? (in the debug
panel)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Removing GUI for the xbl-preference [Moved to bug 412490]

Comment 8

[Mike Kaply [:mkaply]]

This backout caused the default Mozilla to switch from classic to modern.

I checked this repeatedly to make sure it was the cause.

Comment 9

[Brian Ryner (not reading)]

mkaply, are you seeing that on an existing profile or a new profile?  Installing
over an existing build?

Comment 10

[Mike Kaply [:mkaply]]

Any time you create a new profile, you have this problem.


You also see modern for all the profile manager stuff now.

Comment 11

[Alfred Kayser]

Please reopen, cleanup is not complete. The preference itself should also be reset
(or ignored) as Mozilla now tries to use XBL forms, when enable, but due to the
missing forms.jar everything (such as Debug/Viewer Demos/#8 Forms) becomes a mess.

Comment 12

[Mike Kaply [:mkaply]]

I am going to reopen this.

Alfred is correct.

You can't just remove the jar.

You need to remove the preference from the dialog and #if 0 the code in
CSSFrameConstructor and nsChromeRegistry so noone accidentally does this.

Comment 13

[Serge Gautherie (:sgautherie)]

It seems <forms.jar> is (still) not packaged with Trunk Firefox/SeaMonkey/Thunderbird.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070315 SeaMonkey/1.5a] (nightly) (W2Ksp4)

But SeaMonkey still has that debug UI entry.

Comment 14

[Phil Ringnalda (:philor)]

Fixed by bug 412490.

Comment 15

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)

Ftr, CSSFrameConstructor part was removed by bug 473390.

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) all.js: Remove obsolete preference [Checkin: Comment 17]

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 370216 [details] [diff] [review]
(Cv1) all.js: Remove obsolete preference
[Checkin: Comment 17]


http://hg.mozilla.org/mozilla-central/rev/5979cfc7ead5