Migrate debugQA preferences to the new pref window.

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 297229 [details] [diff] [review]
The fix (diff -w)

Part of the ongoing effort, this one is the debugQA extension's preferences.

The patch does the necessary and also fixes a couple of errors I saw in the old pref window (wrong preferences being toggled), and drops some unneeded grid code.
Attachment #297229 - Flags: review?(neil)
(Assignee)

Comment 1

10 years ago
Created attachment 297230 [details] [diff] [review]
The fix (normal patch)
Attachment #297230 - Flags: review?(neil)

Comment 2

10 years ago
from past talks with roc, we don't expect XBL-Forms to continue to work, we can probably drop that pref with this migration.

Comment 3

10 years ago
Comment on attachment 297229 [details] [diff] [review]
The fix (diff -w)

>+      <preference id="print.use_global_printsettings"
>+                  name="print.use_global_printsettings" type="bool"/>
>+      <preference id="extensions.dss.enabled" name="extensions.dss.enabled"
>+                  type="bool"/>
Might as well put the name on the next line, slightly less inconsistent.

>-          <row align="center">
>+      <hbox>
Missing align. r=me with this fixed.

>+      <preference id="nglayout.debug.crossing_event_dumping"
>+                  name="nglayout.debug.crossing_event_dumping"
>+                  type="bool"/>
Might as well put the type on the same line, slightly less inconsistent.
Attachment #297229 - Flags: review?(neil) → review+

Updated

10 years ago
Attachment #297230 - Flags: review?(neil)
(Assignee)

Comment 4

10 years ago
Patch checked in with comments address, I also dropped the XBL-Forms pref at the same time (KaiRo also thought it was ok).

Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.