Created attachment 297229 [details] [diff] [review] The fix (diff -w) Part of the ongoing effort, this one is the debugQA extension's preferences. The patch does the necessary and also fixes a couple of errors I saw in the old pref window (wrong preferences being toggled), and drops some unneeded grid code.
Attachment #297229 - Flags: review?(neil)
Created attachment 297230 [details] [diff] [review] The fix (normal patch)
from past talks with roc, we don't expect XBL-Forms to continue to work, we can probably drop that pref with this migration.
Comment on attachment 297229 [details] [diff] [review] The fix (diff -w) >+ <preference id="print.use_global_printsettings" >+ name="print.use_global_printsettings" type="bool"/> >+ <preference id="extensions.dss.enabled" name="extensions.dss.enabled" >+ type="bool"/> Might as well put the name on the next line, slightly less inconsistent. >- <row align="center"> >+ <hbox> Missing align. r=me with this fixed. >+ <preference id="nglayout.debug.crossing_event_dumping" >+ name="nglayout.debug.crossing_event_dumping" >+ type="bool"/> Might as well put the type on the same line, slightly less inconsistent.
Attachment #297229 - Flags: review?(neil) → review+
Patch checked in with comments address, I also dropped the XBL-Forms pref at the same time (KaiRo also thought it was ok). Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.