1723137 - Create a shared module for PDF creation

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Now that Marionette lives under /remote we should combine the individual PDF implementations for Marionette and CDP into a shared module like /remote/shared/PDF.js. This would allow us to more easily implement the feature for WebDriver BiDi at a later time.

We should probably take the implementation from:
https://searchfox.org/mozilla-central/source/remote/marionette/print.js

Also the following extra work would be needed:

• Use IOUtils.readUTF8() instead of String.fromCharCode()
• As best also create some basic wdspec tests under webdriver/tests/print

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #0)

• Use IOUtils.readUTF8() instead of String.fromCharCode()

Actually in our case we don't have to read from a file, but have a string with the PDF generated data. So this cannot be used.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1723137: Create a shared module for PDF creation. r=whimboo

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deb8b0330528
Create a shared module for PDF creation. r=whimboo,webdriver-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/deb8b0330528