1723215 - Merge local and remote objdir prefs

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement)

Description

[Markus Stange [:mstange]]

If you use about:debugging to profile a Firefox for Android build which you compiled locally, you need to have your objdir in the objdir list so that you get correct symbols.
However, we currently have two places where objdirs can be added:

1. For local profiling, on about:profiling.
2. For remote profiling, if you follow the Settings link in about:debugging's profiling panel.

The two lists are stored in different about:config preferences: devtools.performance.recording.objdirs and devtools.performance.recording.objdirs.remote.

This makes it a little too easy to use the wrong list. Users may not realize that the two lists are stored separately, and may go to about:profiling, add their Android build objdir, and then get disappointed by bad symbols.
Furthermore, you almost never need to specify objdirs for local profiling. (The only scenario I'm aware of is when you use ./mach package on a macOS or Linux build, extract the build from the package again, and then profile it. ./mach package strips symbols.)

I propose that we merge the two settings into one. Adding your android objdir on about:profiling should be enough to get working symbols for remote profiling.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1723215 - Merge local and remote objdir prefs. r=canaltinova

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5a5b4c481e4
Merge local and remote objdir prefs. r=canaltinova

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a5a5b4c481e4