Closed
Bug 1723763
Opened 3 years ago
Closed 2 years ago
Add test case for action API + manifest v3 on Android
Categories
(WebExtensions :: Android, task, P2)
WebExtensions
Android
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1768839
People
(Reporter: robwu, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [mv3-m2])
Bug 1706398 implemented the action
key in manifest.json. It did however not add test coverage on Android.
Currently we have browser_action tests:
- base tests at https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ExtensionActionTest.kt#59
- MV2
browser_action
manifest v2 at https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/mobile/android/geckoview/src/androidTest/assets/web_extensions/actions/manifest.json#2,11
To resolve this bug we have to add a test that uses manifest v3 + "action"
.
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P2
Whiteboard: [mv3-m2]
Updated•3 years ago
|
Updated•3 years ago
|
Points: --- → 2
Reporter | ||
Comment 1•2 years ago
|
||
bug 1768839 is adding a mochitest. That suffices, we don't necessarily need a kt test, because the integration in the Android embedder is sufficiently covered via AppTestDelegate in the mochitest.
(AppTestDelegate was introduced to reduce the need for writing kt tests for extension-specific stuff that could otherwise have been written as a mochitest).
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•