Closed Bug 1723956 Opened 4 years ago Closed 4 years ago

--without-sysroot in configure flags appears to be ignored

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox90 unaffected, firefox91 unaffected, firefox92 fixed, firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox90 --- unaffected
firefox91 --- unaffected
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: jseward, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

(w/ apologies for incorrect Product/Component choice; please re-target)

This is a follow-on from bug 1723953. That was about failures in configure
when building with GCC on Linux. A possible workaround to that bug is to
configure with --without-sysroot, but that also fails -- it seems as if the
request to ignore the ~/mozbuild sysroot is ignored.

This is on Fedora 33, x86_64, gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1).

mozconfig and config.log are attached.

Attached file mozconfig
Attached file config.log
Assignee: nobody → mh+mozilla
Product: Core → Firefox Build System
Regressed by: 1721514
Has Regression Range: --- → yes

Also make it not bootstrap a host sysroot.

Set release status flags based on info from the regressing bug 1721514

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/9e46bdf03189 Make --without-sysroot work again. r=firefox-build-system-reviewers,mhentges

Backed out for causing build bustages.

Push with failures

Failure log

Backout link

Flags: needinfo?(mh+mozilla)

gah, bad rebase.

Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/a1a730897df8 Make --without-sysroot work again. r=firefox-build-system-reviewers,mhentges
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/722284bed619 Make --without-sysroot work again. r=firefox-build-system-reviewers,mhentges
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Comment on attachment 9234808 [details]
Bug 1723956 - Make --without-sysroot work again.

Beta/Release Uplift Approval Request

  • User impact if declined: Build failures related to sysroots can't be worked around with --without-sysroot.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch is a no-op for automation.
  • String changes made/needed: N/A
Attachment #9234808 - Flags: approval-mozilla-beta?

Comment on attachment 9234808 [details]
Bug 1723956 - Make --without-sysroot work again.

Approved for 92.0b3.

Attachment #9234808 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: