1724185 - Values containing an equal character in search filter for LDAP address book are broken

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Pier-Luc Thériault]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I have an address book with this search filter in the form (memberof=cn=Group,dc=domain,dc=local) that I use to filter a subset of my LDAP directory

Actual results:

There is no result at all since the value is cut at the first equal character and become (memberof=cn)

Expected results:

The filter value should be included entirely and the search should return results.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

Fix the case of filter string like (memberof=cn=Group,dc=domain,dc=local), find the position of the first equal symbol and split from there.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e60063c4eb75
Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

Comment 3

[Ping Chen [:rnons] (away)]

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: If filter string contains multiple equal symbols, search doesn't work
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Triage Comment]
Approved for 92.0b1

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 92.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/5414ae79dc23

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/79b192260ff1