Closed
Bug 1724492
Opened 3 years ago
Closed 3 years ago
Stop using nsIAutocompleteResult in UrlbarProviderPlaces
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
To implement top hits in bug 1723160, we need to surface frecency values for Places results. That's not easy right now because they're converted from nsIAutocompleteResult results, which don't expose frecencies. We can stop using nsIAutocompleteResult and instead use simple JS objects.
|
Assignee | |
Updated•3 years ago
|
Iteration: --- → 93.1 - Aug 9 - Aug 22
|
|
Assignee | |
Comment 1•3 years ago
|
||
This will help me fix bug 1723160 by letting me add frecency values to Places
result payloads.
I tried to keep this simple and only do what was necessary to fix the bug. Of
course there's a lot more cleanup we could do, like skip the whole conversion
between match objects and UrlbarResults altogether by only creating
UrlbarResults in the first place, but I didn't want to scope creep into fixing
bug 1717511.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/824f41098467 Stop using nsIAutocompleteResult in UrlbarProviderPlaces. r=harry
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•