1724503 - No indication of current tab in Mac OS Dark Mode + Increase Contrast

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[MarjaE]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. System Preferences > Accessibility > Display > "Increase contrast"

2. System Preferences > General > top row > "Dark"

Actual results:

3. There is no outline around the current tab in the tab bar.

Expected results:

4. There should be an outline, comparable to that in Light Mode + Increase Contrast.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Markus Stange [:mstange]]

Is this a regression?

Comment 3

[MarjaE]

It goes back to at least 2017, and at least 2 redesigns.

Mozregression doesn't work in Dark Mode, so I had to switch back and forth, and it won't work if I keep going back.

Comment 4

[Markus Stange [:mstange]]

Thanks!

Comment 5

[:Gijs (he/him)]

Attachment: Screenshot

Comment 6

[Sarah Clements [:sclements]]

Attachment: Bug 1724503 - Fix for lack of tab indication in dark mode + high contrast r=Gijs

• Add a nested media query for prefers-contrast and prefers-color-scheme: dark

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dded25b0c33
Fix for lack of tab indication in dark mode + high contrast r=Gijs,desktop-theme-reviewers,dao

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5dded25b0c33

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this on Firefox 90.0( 20210705185941) on macOS Big Sur 11. Confirmed as fixed on Firefox 99.0b3(20220313185831) and Nightly 100.0a1(20220313212642).