1725032 - [10.13] After ff91 upgrade, if 'increase contrast' ist checked on mac os, all dialogs have a transparent background, no matter what is set under settings>general>color

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[artcs]

Attachment: Example with print dialog (increase contrast checked/unchecked)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) iCab/5.9.2 Safari/604.5.6

Steps to reproduce:

upgraded to ff91 on mac os 10.13. In os accessibility prefs, 'increase contrast' is checked.

Actual results:

All dialogs (including modal dialogs on the settings page, print dialog and any javascript alert on any page) have a transparent background and are therefore unreadable. Tried all options under settings->general->color (always, never, only high contrast) to no avail. Checked with light and dark mode. Color scheme changes, but dialog backgrounds are always transparent, unless I uncheck the os increase contrast setting.

Expected results:

dialogs should be readable with a opaque background.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Kelimutu [:kiki]]

There's a workaround for this that I found on Twitter. https://twitter.com/dyzurnyklasowy/status/1426216781635624960

Can somebody from the Firefox team confirm if this workaround is safe enough for wide-use? I've been using it as a temporary solution for affected users on Twitter. We have a few users reached out through our forum as well (related discussion: https://support.mozilla.org/en-US/forums/contributors/715221?last=81816), so we need a temporary workaround for this, likely asap, given the pretty significant impact.

Comment 3

[artcs]

This workaround dosen't apply to this problem as already stated in my original post. It will only turn off high contrast mode and restore the intended colors on web pages, all dialogs will remain transparent though, no matter what options you set under settings->general->color.

Comment 4

[Markus Stange [:mstange]]

That's right - what comment 2 refers to is bug 1725341.

This bug about transparent dialog backgrounds is not an intentional change and will be fixed.

Comment 6

[Julien Cristau [:jcristau]]

Bug 1726606 disables high contrast mode by default, even with mac "increase contrast", so marking this as wontfix for 91.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Julien Cristau [:jcristau] from comment #6)

Bug 1726606 disables high contrast mode by default, even with mac "increase contrast", so marking this as wontfix for 91.

Hello Julien! Bug 1726606 should also fix this bug as well? Because I can still see the issue reproducing with the latest nightly and 92.0b7 if Increase Contrast is enabled on macOS 10.13.

Comment 8

[Julien Cristau [:jcristau]]

My bad, I guess this is unrelated.

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1725032 - Override transparent Window system color on 10.13 with a light gray. r=harry

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval ASAP so we can include the fix in our final beta build of the cycle on Thursday.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b1100b49d6e
Override transparent Window system color on 10.13 with a light gray. r=harry

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2b1100b49d6e

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 9237967 [details]
Bug 1725032 - Override transparent Window system color on 10.13 with a light gray. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: For users on macOS 10.13 with the "Increase Contrast" system setting, some dialogs are unintentionally translucent and hard to read.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Extremely low, just hard-codes one system color to a known-good value.
• String changes made/needed:

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with treeherder build from comment 12, Firefox 93.0a1 (20210826031555) on macOS 10.13 and 10.12 while Increase Contrast is enabled. The windows inside about:preferences and modal windows are now displayed as expected.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237967 [details]
Bug 1725032 - Override transparent Window system color on 10.13 with a light gray. r=harry

Approved for 92.0b9.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/113c305e8100

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 92.0b9 (20210826192006) on macOS 10.12 and macOS 10.13 with Increase Contrast.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237967 [details]
Bug 1725032 - Override transparent Window system color on 10.13 with a light gray. r=harry

We're building the Fx92 RC today.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237967 [details]
Bug 1725032 - Override transparent Window system color on 10.13 with a light gray. r=harry

Approved for 91.1esr.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/33d412ef4fc1

Comment 21

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 91.1.0esr (20210728021153) on macOS 10.13 and 10.12 while Increase Contrast is active.