1724509 - Fix some startup cache invalidation issues

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1724509: Part 1 - Annotate crash report with last-startup-was-crash and startup cache status. r=mccr8

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1724509: Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1724509: Part 3 - Remove long-dead binary component fastload cache invalidation code. r=mccr8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b34151a18850
Part 1 - Annotate crash report with last-startup-was-crash and startup cache status. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b267592b49db
Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d47ffc49daff
Part 3 - Remove long-dead binary component fastload cache invalidation code. r=mccr8

Comment 6

[Iulian Moraru]

Backed out for causing marionette failures.

Push with failures

Failure log

Backout link

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Kris is still figuring out why it fails on automation but no luck yet.

Comment 8

[Andrew McCreight [:mccr8]]

At least one of the Marionette tests failing with these patches is test_preloader_telemetry.py. That test involves invalidating the cache, so it makes sense that it would have an effect. I found an issue with how the test deals with failure, and file bug 1757250 for that, but that won't fix the actual issue.

Comment 9

[Andrew McCreight [:mccr8]]

test_preloader_telemetry.py invalidates the cache, then restarts the browser, then waits for cache files to be created, which never happens with the patch. Restarting the browser an extra time makes the test pass. I could see how that might make sense, but I need to get my head around what exactly the invalidation logic is doing here to figure out if needing that change is expected.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Kris, is this something worth resuming that perhaps would help bug 1724336?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/799aaf92ef59
Part 1 - Annotate crash report with last-startup-was-crash and startup cache status. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5569f440c128
Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/c3994fed323f
apply code formatting via Lando

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/799aaf92ef59
https://hg.mozilla.org/mozilla-central/rev/5569f440c128
https://hg.mozilla.org/mozilla-central/rev/c3994fed323f