1757250 - test_preloader_telemetry.py times out if it hits an OSError

Status: RESOLVED FIXED

(Core :: XPConnect, task, P3)

Description

[Andrew McCreight [:mccr8]]

The patch in bug 1724509 changes cache invalidation behavior. This causes test_preloader_telemetry.py to time out, because in wait_for_file_change if the file doesn't exist, then the call to os.stat() throws, and we never run the code to check if the timeout has expired, nor the sleep. The fix is to just hoist those outside of the try except block. Then with bug 1724509 the test at least fails in a reasonable amount of time.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1757250 - Don't skip the time out check in test_preloader_telemetry.py on an OSError.

Comment 2

[Andrew McCreight [:mccr8]]

It looks like this telemetry is due to expire, so maybe the test will get removed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50f45bf25835
Don't skip the time out check in test_preloader_telemetry.py on an OSError. r=dthayer

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/50f45bf25835