1724668 - pocket dialog persists after new url entered

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Timothy Nikkel (:tnikkel)]

Click the save to pocket button on the toolbar. Hit Cmd-L (or ctrl-L) to focus the url field, enter a new url and press enter. I expect the pocket dialog to go away but it persists. Bisected to bug 1693376.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop.

Comment 2

[Scott [:thecount] Downe]

To test (once it has landed):

prerequisite: Be logged into Pocket.

Ensure bug is fixed:

1. Click the save to pocket button on the toolbar.
2. Hit Cmd-L (or ctrl-L) to focus the url field
3. enter a new url and press enter.
   expected: the pocket dialog to go away

Ensure tab specific on Pocket panel didn't regress:

1. Open two different tabs
2. Click the Pocket button in one of the tabs.
3. Hit ctrl+tab
   Expected: should have switched to the next tab, and closed the Pocket panel.

Ensure tab specific on another panel didn't regress:

1. Open two different tabs
2. Click the Bookmarks button in one of the tabs.
3. Click it again and keep it open.
4. Hit ctrl+tab
   Expected: should have switched to the next tab, and closed the Bookmarks panel.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ba2b54d02f6
Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs

Comment 4

[Marian-Vasile Laza]

Backed out changeset 6ba2b54d02f6 (Bug 1724668) for causing bc failures on browser_panel_locationSpecific.js.
Backout link
Push with failures
Failure Log
Also this: Failure Log

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2c05e9aad72c

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 9235677 [details]
Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Pocket dialog user experience impact when it stays open instead of closing. Is confusing to the user, and requires interaction from the user to resolve (close the dialog).
• User impact if declined: Pocket dialog user experience impact when it stays open instead of closing. Is confusing to the user, and requires interaction from the user to resolve (close the dialog).
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a medium sized code change, but it has baked in nightly and beta for a good while now and have not seen a known regression.
• String or UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235677 [details]
Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop.

Approved for 91.2esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/904824f68a9a