1724675 - The button from the “Synced Tabs” doorhanger is missing the label

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: SyncTabs.png

[Affected Versions]:

• Firefox RC 91.0 (Build ID: 20210804193234)
• Firefox Nightly 92.0a1 (Build ID: 20210808090543)

[Affected Platforms]:

• Windows 10 x64
• macOS 11.4
• Ubuntu Linux 20.04 x64

[Prerequisites]:

• Have a Firefox installed.
• Have no Firefox account signed in.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Right click the “Toolbar” and select the “Customize toolbar…” option.
3. Drag and drop the “Synced Tabs” item on the “Toolbar”.
4. Click the “Done” button located on the bottom right corner of the browser.
5. Click the “Synced Tabs” item and observe the button’s label.

[Expected results]:

• The “Sign in to sync...” label is displayed.

[Actual results]:

• The button has no label.

[Regression Window]:

• Since this issue is not reproducible with the Firefox Nightly version from 2021-06-05, using the Mozregression tool we have managed to find the following regression window:
• Last good revision: c4df06014261c1b0ad737c849169fa9db8850679
• First bad revision: 709e714addde7001e05f0b9b6c0df0485b570cf5
  Pushlog:
• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c4df06014261c1b0ad737c849169fa9db8850679&tochange=709e714addde7001e05f0b9b6c0df0485b570cf5

From the pushlog it seems that bug 1698883 has caused this regression.

[Notes]:

• Attached is a screenshot of the issue.
• The issue is also reproducible if a FxA account is logged in without any tabs to sync from other devices.
• The issue is not reproducible in Firefox Release 90.0.2.

@Mike Conley, can you please weigh in on this? Also, even though the regression is from the "Theme" component, I have verified that the issue is reproducible on the default themes and on several "Recommended Themes".

Given the above, I think that the "Toolbars and Customization" component is more suitable. Feel free to change this accordingly if you think otherwise.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Looking.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1724675 - Ensure Synced Tabs panel CtA button label is visible. r?mhowell!

In bug 1698883, a more general rule was removed that made the label for
the Synced Tabs panel CtA button visible: https://hg.mozilla.org/integration/autoland/rev/0ff3ea52f07954501fbcfe9e6abe2a62cfb37d9b#l7.13

Since that rule isn't around anymore, we tell the Synced Tabs button
explicitly to display itself. Thankfully, we no longer need to override
the text-align property with !important, since that was in the original
rule that was removed, and the text-shadow is already being set to none
in another rule for this button.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

For release managers looking for cheap ridealongs, presuming this gets r+ and lands, this is a really simple bugfix that I'd be happy to request uplift for.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e3fc642a3b6
Ensure Synced Tabs panel CtA button label is visible. r=mhowell

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0e3fc642a3b6

Comment 6

[Julien Cristau [:jcristau]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

For release managers looking for cheap ridealongs, presuming this gets r+ and lands, this is a really simple bugfix that I'd be happy to request uplift for.

👍

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for uplift.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9235831 [details]
Bug 1724675 - Ensure Synced Tabs panel CtA button label is visible. r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: Users that access the (non-default) Synced Tabs toolbar button when logged out will see a call-to-action panel with a missing label on its primary action.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very, very small well-understood CSS change.
• String changes made/needed: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235831 [details]
Bug 1724675 - Ensure Synced Tabs panel CtA button label is visible. r?mhowell!

Simple CSS fix, approved for 92.0b4 and 91.1esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/09c2fe690383

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/977e4b88de05

Comment 12

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the issue is no longer reproducible by following the steps from the description using Firefox Nightly 93.0a1 (Build ID: 20210815094823) and Firefox Beta 92.0b4 (Build ID: 20210815185614) on Windows 10 x64, macOS 11.4, and Ubuntu Linux 20.04 x64.

I have also verified that the issue is not reproducible if the "Synced Tabs" is added to the "Overflow menu".