1698883 - Remove `panel-footer-menulike` class

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This class was added in bug 1697947 so that footer buttons could match appearance with footer menu panel items.

Once Proton ships, we should remove that class and turn the buttons into toolbarbutton menuitems like in our other panels (see the footers of the History and Bookmarks subviews, for example).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1698883 - Remove the panel-footer-menulike class. r?prathiksha!

We kept this class around so that we could toggle back and forth between the
Photon-era footer button style, and the Proton-era menuitem style for footer
buttons.

Now that v89 has shipped, we can remove that class and switch the markup and
styling over completely to the Proton styling.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e88b44182dda
Remove the panel-footer-menulike class. r=mhowell

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out for:Backed out changeset e88b44182dda (bug 1698883) for causing bc failures in browser_documentnavigation.js and browser_protectionsUI.js.
https://hg.mozilla.org/integration/autoland/rev/53a0fba120662171047be81a22aaffec98cf1152

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=TSPkLBXBSweuj4ddAnOCFQ.0&revision=e88b44182ddae0b7a2fc448293f8264c9ebed541

https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ACXLdshxTYykLJL99F1tvA.0&revision=e88b44182ddae0b7a2fc448293f8264c9ebed541

Failure log browser_protectionsUI.js:
https://treeherder.mozilla.org/logviewer?job_id=343120496&repo=autoland&lineNumber=2443
Failure log browser_documentnavigation.js:
https://treeherder.mozilla.org/logviewer?job_id=343126740&repo=autoland&lineNumber=2762

Comment 4

[Alexandru Michis [:malexandru]]

Update: also caused failures in browser_toolbarButtonKeyPress.js.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1698883 - Use :focus-visible rather than :focus for panel focus ring rules. r?Itiel!

Depends on D117553

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ff3ea52f079
Remove the panel-footer-menulike class. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/709e714addde
Use :focus-visible rather than :focus for panel focus ring rules. r=Itiel,desktop-theme-reviewers

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0ff3ea52f079
https://hg.mozilla.org/mozilla-central/rev/709e714addde