1724856 - editor should flush pending layout at starting to handle some edit actions

Status: ASSIGNED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Currently, editor tries to flush pending notifications only when it requires layout information. However, we're going to refer layout information more for aligning editor behavior to Blink/WebKit because they refer layout info more frequently than Gecko and they flush pending layout a lot. For the start, let's flush pending notifications when each public method of editor is called.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Hmm, probably, this is wrong thing. Changing style from JS, and then, accessing the editor before a reframe, then, editor is destroyed by the flush at starting to handle an edit command. So, perhaps, we should not do this widely, but I guess that it'd be required by only some edit handlers.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Okay, I think that some edit actions require the latest layout information, but do not flush pending layout by themselves. That makes some tests hack before using the features. We should fix it.