1731005 - HTMLEditor::GetActiveEditingHost() does not return editing host if selection is collapsed in `<input>`

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If we flush pending notifications before calling execCommand in insert-*-in-void-element.tentative.html, HTMLEditor does not work because GetActiveEditingHost() returns nullptr. This is wrong because Selection cannot cross native anonymous subtree boundaries and the selection collapsed in <input> element is valid. Therefore, it should not check whether the content has independent selection or not.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1731005 - HTMLEditor::GetActiveEditingHost() does not return editing host if selection is collapsed in `<input>` r=m_kato!

If we flush pending notifications before calling execCommand in
insert-*-in-void-element.tentative.html, HTMLEditor does not work because
GetActiveEditingHost() returns nullptr. This is wrong because Selection
cannot cross native anonymous subtree boundaries and the selection collapsed in
<input> element is valid. Therefore, it should not check whether the content
has independent selection or not.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149a7c7573f2
HTMLEditor::GetActiveEditingHost() does not return editing host if selection is collapsed in `<input>` r=m_kato

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/149a7c7573f2

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30883 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot