1724906 - Always use double colon for the "after" and "before" pseudo-elements

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We have still places we use only one colon for after and before. We should fix this to be consistent.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1724906-pseudo-elements.patch

I checked also other pseudo classes and this are the only which need a fix.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9235556 [details] [diff] [review]
1724906-pseudo-elements.patch

Review of attachment 9235556 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for taking care of this.
Just a few nits.

::: mail/components/im/messages/papersheets/main.css
@@ +95,5 @@
>  p.action>span.message-style {
>    font-style: italic;
>  }
>  
> +p.action>span.message-style::before {

nit: since we're editing this maybe we could add a space between the > symbol for consistency.

::: mail/components/im/messages/simple/main.css
@@ +27,4 @@
>    content: " - ";
>  }
>  
> +.action>span.date::after {

same here

@@ +35,4 @@
>    content: ": ";
>  }
>  
> +.action>span.pseudo::after {

and here

@@ +39,4 @@
>    content: " ";
>  }
>  
> +.event>span.pseudo::after {

and here

::: mail/themes/shared/openpgp/enigmail-common.css
@@ +122,5 @@
>    float: left;
>    border-radius: 4px;
>  }
>  
> +.enigmailCaptionbox>h1::before {

here

@@ +131,5 @@
>    width: 0.75em;
>    border-radius: 4px;
>  }
>  
> +.enigmailCaptionbox>h1::after {

here

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1724906-pseudo-elements.patch

Added spaces around the >.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af196016a28b
Always use double colon for the "after" and "before" pseudo-elements. r=aleca