1724985 - Remove osfile.jsm from RemoteL10n.jsm

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P3)

Description

[Beth Rennie [:beth] (she/her)]

The usage of osfile.jsm in RemoteL10n should be replaced by IOUtils / PathUtils.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1724985 - Remove OS.File from RemoteL10n.jsm and associated tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/781b6946a619
Remove OS.File from RemoteL10n.jsm and associated tests r=andreio

Comment 3

[Cristian Tuns]

Backed out for causing for causing mochitest failures

• Backout link
• Push with failures
• Failure Log

Comment 4

[Andreea Pavel [:apavel]]

This also caused failures at browser_popupNotification_hide_after_protections_panel.js

Failure log: https://treeherder.mozilla.org/logviewer?job_id=356900938&repo=autoland&lineNumber=1986

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=4489ad079ac17c4d2211830499b8ce3b8ca47e08&searchStr=windows%2C10%2Cx64%2C2004%2Casan%2Cwebrender%2Copt%2Cmochitests%2Ctest-windows10-64-2004-asan-qr%2Fopt-mochitest-browser-chrome-e10s%2Cbc2&tochange=ca34b82f29331eb91883fa16601399d6428bced8&selectedTaskRun=QYwCeWMQTCS7LzCXWYngxg.0

Comment 5

[Emily McMinn :emcminn]

I haven't been able to duplicate the failures locally, but I've updated the patch and am giving it another shot on try.

EDIT: We found the issue, it had to do with the difference in path handling between platforms. I have a new patch up waiting to land; I'm still seeing a single failure on try but it looks like a known intermittent:
https://treeherder.mozilla.org/push-health/push?repo=try&revision=6acf390a90a253271ed17838a2102acc73611f7f&tab=tests&testGroup=pr&selectedTest=browserbasecontenttestformsbrowserselectpopupjs&selectedTaskId=357390706&selectedJobName=browser%2Fbase%2Fcontent%2Ftest%2Fforms%2Fbrowser_selectpopup.js+test-windows10-64-2004-qr%2Fopt-mochitest-browser-chrome-fis-e10s-5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f484174dd51
Remove OS.File from RemoteL10n.jsm and associated tests r=andreio

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/7f484174dd51