1749644 - RemoteL10n looking for translations in wrong locaation

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, defect, P1)

Description

[Beth Rennie [:beth] (she/her)]

Bug 1724985 ported RemoteL10n.jsm to use IOUtils & PathUtils, but ended up using the profile directory instead of the local profile directory as the lookup directory for downloaded translation files.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1749644 - Fix RemoteL10n Fluent directory r?emcminn

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1724985

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32bd016e3d08
Fix RemoteL10n Fluent directory r=emcminn

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/32bd016e3d08

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Can you please clarify what the user-facing impact of this bug is? On the surface, this sounds like something we may want in a dot release.

Comment 6

[Beth Rennie [:beth] (she/her)]

:RyanVM right now if we wanted to launch any sort of targeted campaign with off-train translated strings (via RemoteL10n), the strings would not be able to found and the campaign would show e.g., blank messages in CFR or Spotlight.

Comment 7

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9258599 [details]
Bug 1749644 - Fix RemoteL10n Fluent directory r?emcminn

Beta/Release Uplift Approval Request

• User impact if declined: We cannot launch any targeted messaging campaigns with off-train translated strings. Any such campaign would display empty dialogs or messages to end users.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a reversion of a path change from bug 1749644. I have verified that RemoteL10n works correctly with this patch applied.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9258599 [details]
Bug 1749644 - Fix RemoteL10n Fluent directory r?emcminn

Approved for 97.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3e226f4123d

Comment 10

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9258599 [details]
Bug 1749644 - Fix RemoteL10n Fluent directory r?emcminn

Beta/Release Uplift Approval Request

• User impact if declined: We cannot launch any targeted messaging campaigns with off-train translated strings. Any such campaign would display empty dialogs or messages to end users.

We (OMC) do not consider this high enough priority to be a dot release driver, but are happy to take it as a ride along.

• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a reversion of a path change from bug 1749644. I have verified that RemoteL10n works correctly with this patch applied.
• String changes made/needed:

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9258599 [details]
Bug 1749644 - Fix RemoteL10n Fluent directory r?emcminn

Approved by 96.0.2

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/e851157242f2