1725144 - composeAction API: “Error: Internal error: Type IconPath not found”

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Teal Dulcet [:tdulcet] (TB Council)]

browser.composeAction.setIcon() throws these errors:

Error: Internal error: Type IconPath not found Schemas.jsm:1602:13
Uncaught DOMException: An exception was thrown debugger eval code:1:23

mozregression returns this result:

2021-08-11T03:57:18.112000: INFO : Narrowed nightly regression window from [2021-05-18, 2021-05-21] (3 days) to [2021-05-20, 2021-05-21] (1 days) (~0 steps left)
2021-08-11T03:57:19.163000: DEBUG : Found commit message:
Bug 1712058 - Flip default value for browser_style in cloudFile API from true to false and fix some descriptions and type definitions. r=mkmelin

Differential Revision: https://phabricator.services.mozilla.com/D115600

2021-08-11T03:57:19.163000: INFO : The bisection is done.

It would be great if the fix for this regression could be uplifted to TB 91, as it is affecting an add-on I just published to ATN.

Comment 1

[AppDev]

I get the same error for messageDisplayAction:

browser.messageDisplayAction.setIcon({
  path: {
    64: "images/myimage.png",
  },
  tabId: currentTabId,
});

Comment 2

[AppDev]

Bug still present in TB 91.0.1

Comment 3

[John Bieling (:TbSync)]

Attachment: Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9753440e197a
Fix schema definitions of action buttons involving IconPath type. r=mkmelin

Comment 5

[Uplift Request]

Time for uplift requests?

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9236873 [details]
Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Icons of action buttons cannot be changed

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9236873 [details]
Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 92.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/c2490facf3f6

Comment 10

[Magnus Melin [:mkmelin]]

Uplift to 91?

Comment 11

[John Bieling (:TbSync)]

Comment on attachment 9236873 [details]
Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Icons of action buttons cannot be changed

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9236873 [details]
Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.1.2:
https://hg.mozilla.org/releases/comm-esr91/rev/e167bdd73392