1725177 - ::backdrop with animation does not work

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Tim Nguyen :ntim]

See http://jsfiddle.net/g6u83rmp

Using animations on backdrops doesn't work

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Why should they work? ::backdrop is a box, not an element / tree-abiding pseudo-element like ::before / ::after / ::marker.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Err, Brian, do you agree with the above? Or am I missing something?

Comment 3

[Brian Birtles (:birtles)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Err, Brian, do you agree with the above? Or am I missing something?

Sorry, I'm completely unfamiliar with ::backdrop but I believe George Steel from Google was working on making all pseudo-elements animatable in Blink over in https://github.com/w3c/csswg-drafts/issues/4502

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Now that animation storage is a bit better defined in bug 1807003, this might be more easily fixable? https://searchfox.org/mozilla-central/rev/e9b8c73771d0038214c69f17c5934ba8ae049799/dom/animation/ElementAnimationData.h#101-105

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1725177 - Make ::backdrop a real generated content pseudo-element. r=#layout

This allows animating ::backdrop and addresses long-standing animation
issues.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45879990e9f1
https://hg.mozilla.org/integration/autoland/rev/04ec3b143db3
Make ::backdrop a real generated content pseudo-element. r=layout-reviewers,firefox-style-system-reviewers,dshin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dac5cd4d8dde
https://hg.mozilla.org/integration/autoland/rev/df010ea22831
Avoid using `using enum` to fix base toolchains build.

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/04ec3b143db3
https://hg.mozilla.org/mozilla-central/rev/df010ea22831

Comment 12

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #10)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dac5cd4d8dde
https://hg.mozilla.org/integration/autoland/rev/df010ea22831
Avoid using using enum to fix base toolchains build.

Perfherder has detected a mozperftest performance change from push df010ea22831c4db495e358a91e15ec234cef1c1 / ac2cebf208eb5fb090935cc35a2ec45b8977d1b4.

Do you think it's possible that push df010ea22831c4db495e358a91e15ec234cef1c1 may have caused the improvements referenced below?

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	foreground-resource pss-gpu-start	android-hw-a55-14-0-aarch64-shippable		53,607.92 -> 50,322.67
6%	foreground-resource pss-gpu-end	android-hw-a55-14-0-aarch64-shippable		53,763.96 -> 50,487.92
6%	foreground-resource pss-gpu-10%	android-hw-a55-14-0-aarch64-shippable		53,653.25 -> 50,399.58
6%	foreground-resource pss-gpu-50%	android-hw-a55-14-0-aarch64-shippable		53,711.08 -> 50,495.50
5%	background-resource pss-gpu-10%	android-hw-a55-14-0-aarch64-shippable		53,635.50 -> 50,794.67
5%	background-resource pss-gpu-start	android-hw-a55-14-0-aarch64-shippable		53,583.50 -> 50,907.50

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Please needinfo the right person :)

That improvement is from bug 2005820.