1725223 - "Open in Firefox" button triggers buggy hamburger menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Haik Aftandilian [:haik]]

Attachment: Screenshot demonstrating the problem

Clicking "Open in Firefox" on the Lockwise page https://www.mozilla.org/en-US/firefox/lockwise/ opens the hamburger menu and highlights the passwords entry, but the text is not readable. See screenshot. Secondly, the hamburger is not dismissed by clicking outside of it for example on the page. Dismissing the menu required clicking on an entry or clicking the hamburger menu to dismiss it.

Hit on Firefox 91.0 on macOS 11.5.

Comment 1

[WIlliam Davis [:AwesomeSheep48]]

Reproducible in Firefox 93.0a1 (2021-08-11) (64-bit) on macOS 12.0 Beta (21A5294g)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Can you re-test in the latest Firefox Nightly builds? This might be from a graphics bug that was recently fixed.

Comment 3

[Haik Aftandilian [:haik]]

It's still reproducible.

Here's a mozregression range for the menu highlighting issue. I couldn't narrow the range any further because of an issue with codesigning and the mozregression downloaded builds on Apple Silicon. I'll try to get a smaller range.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=191e4bdf9e08fa81e2986e0a8664794b7ffa7e42&tochange=027aeb3ebc746a154d9b60f8e2e9d4cb538eede5

From the description, Bug 1722799 UITour highlight appears as a solid color rectangle instead of a translucent highlight could be related.

Molly, could you take a look?

It looks like the issue where clicking outside of the menu doesn't dismiss it should be a separate bug. I'll try and mozregression that and file a new bug.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

That's fascinating, because this is exactly the behavior I was fixing in bug 1722799. I'll look into it.

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Okay, so what happened here is that I was depending on a rule which is in the Windows theme without realizing it. Need to carry over the bit of that that I need into the Mac theme. I'll check on Linux also.

Comment 6

[Molly Howell (she/her) (mostly inactive)]

Linux looks okay; it's just Mac.

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1725223 - Use the correct UITour highlight panel color on macOS. r=#desktop-theme-reviewers

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1725223 - Reset native styles of #UITourHighlightContainer properly. r=dao

This is needed for macOS / windows because of this rule:

https://searchfox.org/mozilla-central/rev/36904ac58d2528fc59f640db57cc9429103368d3/toolkit/themes/osx/global/popup.css#12-15

This should be a better fix than double-applying the background.

Longer term it might be worth trying to make panels appearance: none (and no
background / borders on the panel itself, only on the contents) by default, and
add a native attribute or such for the ones that should look native, wdyt?

I can look into that if it'd be useful.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1722799

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f22fa11a6b
Reset native styles of #UITourHighlightContainer properly. r=dao

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/24f22fa11a6b

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Presumably we want to uplift this?

Comment 14

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9236157 [details]
Bug 1725223 - Reset native styles of #UITourHighlightContainer properly. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Broken and unusable UITour menu item highlights.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch specifically touches only the UITour highlight element, it shouldn't be able to affect anything else.
• String changes made/needed:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236157 [details]
Bug 1725223 - Reset native styles of #UITourHighlightContainer properly. r=dao

Approved for 92.0b5.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/be61c831c659

Comment 17

[Julien Cristau [:jcristau]]

Might be worth fixing on esr91 too?

Comment 18

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using old Nightly from 2021-08-11, verifiefd that using latest Nightly build 93.0a1 from today and 92.0b6 that this is no longer reproducible. Leaving qe-verify+ until the decision is made for esr91.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236157 [details]
Bug 1725223 - Reset native styles of #UITourHighlightContainer properly. r=dao

Approved for 91.1esr.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/23ab9c2a54db

Comment 21

[Bogdan Maris, Desktop Test Engineering]

Also verified fixed using latest esr91 build from treeherder using macOS 11.5.