Fix or reduce assertion hits of "Given content is not editable" in `WSRunScanner::TextFragmentData::TextFragmentData()`
Categories
(Core :: DOM: Editor, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
A lot of tests expect some assertion hits of the assertion. But it makes hard to change behavior only in Nightly channel because assertion count may be changed in the other channels.
|
Assignee | |
Comment 1•3 years ago
|
||
It tries to delete a text node if it's invisible both selection start and
selection end. However, the selection range may be in a text node. If it's
an invisible, the node is deleted at first call of
DeleteNodeIfInvisibleAndEditableTextNode(), but it keep trying to remove
again with same method.
Depends on D122548
|
|
Assignee | |
Comment 2•3 years ago
|
||
If the point is not editable, white-spaces around it shouldn't be normalized.
Depends on D122561
| Comment hidden (obsolete) |
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
They clean up the tail of descendant block first. At this time, running script
may change one of or both of the left block element and the right block element.
In such situation, they should stop handling to join the blocks because of
unexpected case.
Depends on D122562
|
|
Assignee | |
Updated•3 years ago
|
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/d875e0f7413e part 1: Make `HTMLEditor::AutoDeleteRangesHandler::DeleteUnnecessaryNodesAndCollapseSelection()` try to delete same text node twice r=m_kato
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/103ec049dcf0 part 2: Make `HTMLEditor::OnEndHandlingTopLevelEditSubActionInternal()` guarantee that `WhiteSpaceVisibilityKeeper::NormalizeVisibleWhiteSpacesAt()` is called with editable point r=m_kato
|
|
Assignee | |
Updated•3 years ago
|
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/5df70b1c4daa part 3: Make `WhiteSpaceVisibilityKeeper::MergeFirstLineOf(Right|Left)BlockElementIntoDescendant(Left|Right)BlockElement()` abort handling it if joining elements become non-editable r=m_kato
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/103ec049dcf0
https://hg.mozilla.org/mozilla-central/rev/5df70b1c4daa
Description
•