1725291 - Fix or reduce assertion hits of "Given content is not editable" in `WSRunScanner::TextFragmentData::TextFragmentData()`

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

A lot of tests expect some assertion hits of the assertion. But it makes hard to change behavior only in Nightly channel because assertion count may be changed in the other channels.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1725291 - part 1: Make `HTMLEditor::AutoDeleteRangesHandler::DeleteUnnecessaryNodesAndCollapseSelection()` try to delete same text node twice r=m_kato!

It tries to delete a text node if it's invisible both selection start and
selection end. However, the selection range may be in a text node. If it's
an invisible, the node is deleted at first call of
DeleteNodeIfInvisibleAndEditableTextNode(), but it keep trying to remove
again with same method.

Depends on D122548

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1725291 - part 2: Make `HTMLEditor::OnEndHandlingTopLevelEditSubActionInternal()` guarantee that `WhiteSpaceVisibilityKeeper::NormalizeVisibleWhiteSpacesAt()` is called with editable point r=m_kato!

If the point is not editable, white-spaces around it shouldn't be normalized.

Depends on D122561

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1725291 - part 1: Make `HTMLEditor::AutoDeleteRangesHandler::DeleteUnnecessaryNodesAndCollapseSelection()` try to delete same text node twice r=m_kato!

It tries to delete a text node if it's invisible both selection start and
selection end. However, the selection range may be in a text node. If it's
an invisible, the node is deleted at first call of
DeleteNodeIfInvisibleAndEditableTextNode(), but it keep trying to remove
again with same method.

Depends on D122548

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1725291 - part 3: Make `WhiteSpaceVisibilityKeeper::MergeFirstLineOf(Right|Left)BlockElementIntoDescendant(Left|Right)BlockElement()` abort handling it if joining elements become non-editable r=m_kato!

They clean up the tail of descendant block first. At this time, running script
may change one of or both of the left block element and the right block element.
In such situation, they should stop handling to join the blocks because of
unexpected case.

Depends on D122562

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d875e0f7413e
part 1: Make `HTMLEditor::AutoDeleteRangesHandler::DeleteUnnecessaryNodesAndCollapseSelection()` try to delete same text node twice r=m_kato

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d875e0f7413e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/103ec049dcf0
part 2: Make `HTMLEditor::OnEndHandlingTopLevelEditSubActionInternal()` guarantee that `WhiteSpaceVisibilityKeeper::NormalizeVisibleWhiteSpacesAt()` is called with editable point r=m_kato

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5df70b1c4daa
part 3: Make `WhiteSpaceVisibilityKeeper::MergeFirstLineOf(Right|Left)BlockElementIntoDescendant(Left|Right)BlockElement()` abort handling it if joining elements become non-editable r=m_kato

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/103ec049dcf0
https://hg.mozilla.org/mozilla-central/rev/5df70b1c4daa