1727868 - `HTMLEditUtils::IsVisibleBRElement()` shouldn't use `WSRunScanner`

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

WSRunScanner is designed for handling editable contents. However, HTMLEditUtils::IsVisibleBRElement() needs to check it even if the <br> element is in non-editable element. Therefore, we may hit the assertion.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1727868 - Make `HTMLEditUtils::IsVisibleBRElement()` stop using `WSRunScanner` r=m_kato!

The method may be used for checking a <br> element visibility in non-editable
content too. Therefore, using WSRunScanner which is designed for scanning
editable content hits assertions.

The visibility of <br> element is considered only with the following
visible thing. If it's followed only by another or current block boundary,
the <br> element is invisible. But otherwise, it's visible. So, it needs
to scan following contents to look for first visible thing until reaching
a block boundary. And it does not need to check its previous content.

Depends on D123875

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c79c667c59a
Make `HTMLEditUtils::IsVisibleBRElement()` stop using `WSRunScanner` r=m_kato

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0c79c667c59a