1725309 - Font sizing and menulist padding changed after removal of --in-content-* style.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-08-11 21-40-27.png

The font sizing of smaller labels and the padding of the menulists have been affected by the changes introduced in bug 1699439.
Luckily these changes are not in the 91 branch.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1725309-accountCentral-select-padding.patch

This fixes the too tall <select>s. The font is still 0.85em. Maybe it looks too small because of the big <select>s.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9235964 [details] [diff] [review]
1725309-accountCentral-select-padding.patch

Review of attachment 9235964 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the quick fix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5fa94078c3a6
Remove the block padding from <select>. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9235964 [details] [diff] [review]
1725309-accountCentral-select-padding.patch

[Approval Request Comment]
User impact if declined: <select>s in account central too tall
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9235964 [details] [diff] [review]
1725309-accountCentral-select-padding.patch

[Triage Comment]
approved for beta (not yet on nightly, but clearly trivial)

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-08-13 12-27-31.png

We missed the menulist in the calendar HTML dialog in the account setup page.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1725309-calendar-select.patch

Style the "Connect calendar" <select> like the other <select>s.

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9236259 [details] [diff] [review]
1725309-calendar-select.patch

Review of attachment 9236259 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9137c2de4321
Style the "Connect calendar" select correctly. r=aleca

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 9236259 [details] [diff] [review]
1725309-calendar-select.patch

[Approval Request Comment]
User impact if declined: too tall select in Connect calendar dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9236259 [details] [diff] [review]
1725309-calendar-select.patch

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 92.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/dbe78ced6d40
https://hg.mozilla.org/releases/comm-beta/rev/7979666a3d84