Closed Bug 172541 Opened 23 years ago Closed 21 years ago

Change "Custom wav file" to "Custom sound file" in MailNews prefs

Categories

(SeaMonkey :: MailNews: Message Display, defect)

PowerPC
macOS
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 266192

People

(Reporter: bugmail, Assigned: sspitzer)

References

Details

(Whiteboard: File to patch is chrome/en-US/locale/en-US/messenger/pref-mailnews.dtd)

Attachments

(1 file)

Presuming Mozilla can play sound formats other than wav, Mozilla shouldn't refer specifically to a single proprietary sound format in it's new-mail-sound prefs. Instead of "Custom wav file", we should use "Custom sound file".
Attached patch Patch — — Splinter Review
Keywords: patch, review
seth, would this be in your area? reassign if needed.
Assignee: ben → sspitzer
Component: Preferences → Mail Window Front End
Product: Browser → MailNews
QA Contact: sairuh → olgam
I believe we can only handle .wav files at the moment? Hence why that wording was picked.
> I believe we can only handle .wav files at the moment? > Hence why that wording was picked. Currently it says "wav" not ".wav" file. If the wording is going to be changes, could the capitalisation be sorted out at the same time? "System New Mail Sound" isn't consistent with "Custom wav file".
The Mac nsISound implementation can actually play any sound format that Quicktime handles (e.g. aiff, wav, mp3 etc). Yes, you could set this sound file to be a 5-minute MP3 ;)
QA Contact: olgam → stephend
Looks like my original patch correctly; it replaces the whole DTD file. I'll try to make another. Should this be a Mac-only change, or can Mozilla handle multiple non-WAV formats on all platforms?
Whiteboard: File to patch is chrome/en-US/locale/en-US/messenger/pref-mailnews.dtd
Product: Browser → Seamonkey
*** Bug 271485 has been marked as a duplicate of this bug. ***
I'll add this into the next patch for bug 266192 so marking as a dupe *** This bug has been marked as a duplicate of 266192 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
verified dup
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: