Disable toolbar button when new screenshots UI is showing
Categories
(Firefox :: Screenshots, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: kajalsah107)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When screenshots.browser.component.enabled is true and we bring up the screenshots UI, we don't disable the screenshots button. We need to send the toggle-screenshot-disable notification when we open the tab dialog box https://searchfox.org/mozilla-central/rev/3a8091d1c29473a0839ad7a5810028f41363fe2e/browser/components/screenshots/ScreenshotsUtils.jsm#20-25 and when we close it https://searchfox.org/mozilla-central/rev/3a8091d1c29473a0839ad7a5810028f41363fe2e/browser/components/screenshots/content/screenshots.js#47,94,140.
It may make sense to have a close() helper in screenshots.js that handles the notification and window.close() function each time.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
I was not able to reproduce this issue on Firefox 93.0a1 (2021-08-12) but I noticed something else, if I toggle the screenshot button, immediately it becomes disabled, then change the tab (click on the next tab) and after this came back to the initial tab where you take a screenshot, now the screenshot button is enabled. This happens on latest nightly and on 93.0b7 beta builds. This is expected or is related to this issue itself? Thanks!
Description
•