1696573 - [Meta] Move screenshots into a dedicated browser component

Status: NEW

(Firefox :: Screenshots, enhancement, P2)

Description

[Emma Malysz]

Screenshots is currently maintained as an internal add-on in browser/extensions/screenshots. Since this code is now maintained in tree, it should have a dedicated browser component and use a module instead of relying on extensions code.

This bug can track the refactoring efforts on this code.

A good place for this to ultimately reside would be in browser/components/screenshots

Comment 1

[Dhanesh]

okay .then we need to just cut the 'screenshots' folder and paste it over the browser/components. Incase in some files,exporting and importing codes has path directed to files in extension folder then we need to rewrite the path to the components folder. Then It would be right ?

Comment 2

[Emma Malysz]

Hi Dhanesh, no the work will be more complicated than simply moving files around.

An example of a dedicated browser component would be: browser/components/customizableui/PanelMultiView.jsm. All the code relating to PanelMultiView is maintained there, and it's easily accessible to other browser components and files in the tree.

Screenshots, on the other hand, are currently maintained as an extension. There are multiple files that would need to be ported over and consolidated into one dedicated browser component, so it would be a large scale code refactor.

This will be one of the main projects for the selected outreachy applicant and will take a few weeks to complete.

Comment 3

[Sam Foster [:sfoster] (he/him)]

i'm making this a meta bug, as it involves a lot of separate steps.

Comment 4

[taran]

Hello, all.
My apologies if this is the wrong place/time/whatever to post this.
I'm a full-time video editor. I take a lot of screenshots of web pages. A LOT.
I've tried just about every screenshot tool/app/add-on that there is.
I used to use a Firefox add-on called "Screengrab!" which had all the functionality I wanted. However, I came to learn that from a security perspective, it was pretty sketchy, so I had to abandon it. After that, I had to switch to Chrome, simply because its screenshot functionality is superior to Firefox. And I'd really prefer to use Firefox. But I can't, unless its screenshot function improves.

Here are the mandatory features I need in a browser-based screenshot tool:

• Secure
• Full page ("extended active window")
• Use browser scaling
• .png
• Instantaneous (no scrolling, taking another screenshot, scrolling, taking another screenshot, then stitching them together)

Firefox's current screenshot tool (where you press CTRL SHIFT S) does not use the current scaling/"zoom level," making it useless to me. (It also requires a bunch of extra clicking, which is very annoying when you do this dozens of times pre day.)
However, If I use the console command ":screenshot --fullpage --dpr 2", Firefox DOES have all the above features. But again, due to the additional quality-of-life features that Chrome has, I switched to it. Below are those QOL features that I'd like to see in Firefox:

• Can be activated with a (customizable!) keyboard shortcut.
• (Save As...) Specify LOCATION
• Save As location is remembered
• (Save As...) Specify FILENAME
• Single step - no extra clicking

Here's my spreadsheet comparing screenshot tools in several browsers:
https://docs.google.com/spreadsheets/d/1dVJb7kI_ZETLavrplfARgn9gL8HUpvkq6A0jCPxqA3w/edit#gid=50892840

And here's an older video I made about this topic:
https://www.youtube.com/watch?v=3JFvV6s0IH0

So uh, conclusion! Please include as many of these features as possible... preferably all of them! ...and you'll have the best screenshot tool around, and I can finally switch back to Firefox. Thank you!
I can answer any questions you might have.

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to taran from comment #4)

My apologies if this is the wrong place/time/whatever to post this.

Thanks for all the input there. This bug is about some specific engineering work we are doing - which won't be changing or adding any features. Could you re-post your ideas on ideas.mozilla.org / general?

Or, you could file bugs for each of the items in your list: keyboard shortcut (actually exists, but not customizable), save as / file name and location, reduce steps/click.

Firefox's current screenshot tool (where you press CTRL SHIFT S) does not use the current scaling/"zoom level," making it useless to me. (It also requires a bunch of extra clicking, which is very annoying when you do this dozens of times pre day.)

We may have this on file already, but if you can file a bug for this with any detail you can provide on specific cases where it doesn't do what you expect we can take a look.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:sfoster, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #6)

Redirect a needinfo that is pending on an inactive user to the triage owner.
:sfoster, since the bug has high priority and recent activity, could you have a look please?

No action needed here. In the interim, connected.mozilla.org has been stood up and were are monitoring that for feature discussion and suggestions.