1725460 - Folder pane toolbar disappears after restart

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[IT Support]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36 Edg/92.0.902.67

Steps to reproduce:

The folder pane toolbar behaves erratically. It disappears on many occasions after restart when it shouldn't. One way to reliably show the problem is this:
Hide the toolbar from the toolbar menu. Toolbar gone.
Display it again via "View > Toolbars". Toolbar there.
Restart.

Actual results:

Toolbar gone.

Expected results:

State of folder pane toolbar should be persisted.

There are other occasions on which the toolbar disappears, but they are not reproducible at will.

Found be a real user of the product in the first 24h after installation.

Comment 1

[Alessandro Castellani [:aleca]]

Good catch, I'll take care of this.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1725460 - Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d2a42c987df
Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9236044 [details]
Bug 1725460 - Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: The Folder pane toolbar doesn't remain visible after restart
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, as this patch only removes the initial collapsed state of that toolbar

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9236044 [details]
Bug 1725460 - Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/ac603431e5cb

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9236044 [details]
Bug 1725460 - Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: The Folder pane toolbar doesn't remain visible after restart
Testing completed (on c-c, etc.): on c-c and beta
Risk to taking this patch (and alternatives if risky): low, as this patch only removes the initial collapsed state of that toolbar

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9236044 [details]
Bug 1725460 - Remove the initial collapsed state of the Folder Pane Toolbar. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/c6cbc84436bf

Comment 10

[WaltS48 [:walts48]]

Verified testing the 91.0.3 release candidate on Windows 10.