1725581 - Use a less opaque drop feedback for the attachments

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Bug 1725164 introduced an almost opaque drop feedback for the attachments in composer.

This bug is to investigate a less opaque feedback.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1725581-drop-feedback.patch

I converted it to variables to made it easier to change the values.

What do you think about this opacities? The title is always readable as I haven't changed his background. I also changed the title border radius to our standard 3px. What do you think about this?

Comment 2

[IT Support]

(In reply to Richard Marti (:Paenglab) from comment #0)

Bug 1725164 introduced an almost opaque drop feedback for the attachments in composer.
This bug is to investigate a less opaque feedback.

We've suggested reverting changes to the background, see attachment 9236142 [details] [diff] [review].

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9236143 [details] [diff] [review]
1725581-drop-feedback.patch

Review of attachment 9236143 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/shared/mail/messengercompose.css
@@ +340,5 @@
> +  --drop-attachment-box-color: #222;
> +  --drop-attachment-box-border-color: #222;
> +  --drop-attachment-box-background-hover: rgba(255, 255, 255, 0.5);
> +  --drop-attachment-box-border-color-hover: #000;
> +  --drop-attachment-title-background: rgba(255, 255, 255, 0.85);

Good improvements.
I think we should use this color also for the border color in light/regular mode.
The #222 border color doesn't look too good.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1725581-drop-feedback.patch

Now with white border.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9236214 [details] [diff] [review]
1725581-drop-feedback.patch

Review of attachment 9236214 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please, update the commit message to: "Bug 1725581 - Use a less opaque drop feedback for the attachments overlay. r=aleca"

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1725581-drop-feedback.patch

Updated the commit message.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b3b22332a024
Use a less opaque drop feedback for the attachments overlay. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1725581-drop-feedback-beta-ESR.patch

Combined patch with the one from bug 1725164

[Approval Request Comment]
User impact if declined: Low contrast when attaching over DnD
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9236306 [details] [diff] [review]
1725581-drop-feedback-beta-ESR.patch

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 92.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c01634422d6b

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9236306 [details] [diff] [review]
1725581-drop-feedback-beta-ESR.patch

[Triage Comment]
Approved for esr91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/631d8c61aaf4