1725674 - TB 91 messages automatically marked as junk are included in the count of unread messages displayed in overlay/badge

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Andy Burns]

Attachment: Screen capture

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Open thunderbird, do a "mark all folders read" on all accounts

Actual results:

The red overlaid message count still shows a (1) for the main window in the task bar, this only happens when Windows10 setting for "use small taskbar buttons" is OFF.

Expected results:

The red circle should only be displayed when there are actually unread messages

Comment 1

[Andy Burns]

If the Windows setting "display badges on taskbar buttons" is turned off, the overlay/badge is not shown.

Comment 2

[José M. Muñoz]

Are you sure this is not an unread chat message? Also look at bug 1721063.

Comment 3

[Andy Burns]

it's possible, I don't have a chat tab open, and thought I'd disabled my chat account since the freenode takeover, but I'll open the chat tab and see if it's related, thanks.

Comment 4

[Andy Burns]

regarding BZ 1721063, I don't get any tooltip when hovering over the window, not to say 1 unread, or 1 new unread, seems a different issue.

Comment 5

[Ping Chen [:rnons] (away)]

I can't reproduce this, did you find anything in the chat tab?

Comment 6

[Andy Burns]

The chat account was disconnected (but trying to connect in the background)

I disabled the auto connect, quit and restarted TB, no "badge"

Re-enabled auto connect, quit and restarted again, still no badge, and it hasn't happened again since. I'd say close it and re-open if it occurs again.

Comment 7

[Magnus Melin [:mkmelin]]

-> WFM per comment 6.

Comment 8

[Andy Burns]

I have had the message count badge re-appear twice since saying it no longer happens

It shouldn't be chat related as I have now deleted the IRC account

Both times, I went to every account and did a "mark all folders read" that didn't remove the badge

no folders show any unread message count, or are bold

If I go into a random folder, and mark a single message as unread, the folder goes bold and shown an unread count of 1, the badge remains, I then read that message and the badge disappears.

Once the badge has gone, marking a single message as unread makes the badge reappear, and reading the message makes it disappear again.

Comment 9

[Andy Burns]

Becoming reasonably convinced this occurs when an email is received, the badge applied, then it is moved to Junk and marked as read, but the badge remains.

Comment 10

[Andy Burns]

Yes, that's it

Twice I've cleared out my junk folder, and each time I saw the red (1) there was a new junk item in there.

Comment 11

[Ping Chen [:rnons] (away)]

I've found a way to reproduce it, will make a fix tomorrow. Thanks.

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: Bug 1725674 - Make sure badge unread count reflects the current state. r=mkmelin

Because _updateUnreadCount is an async function and can be triggered frequently, call itself one more time when needed.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3b326bd35ef
Make sure badge unread count reflects the current state. r=mkmelin

Comment 14

[Ping Chen [:rnons] (away)]

Comment on attachment 9236759 [details]
Bug 1725674 - Make sure badge unread count reflects the current state. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 715799
User impact if declined: New mails automatically marked as junk still counted in the badge
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9236759 [details]
Bug 1725674 - Make sure badge unread count reflects the current state. r=mkmelin

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/06b52dca1a7d

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9236759 [details]
Bug 1725674 - Make sure badge unread count reflects the current state. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/802df9da4ec2

Comment 19

[Andy Burns]

Picked up 91.0.3 on release channel, confirm fixed, thanks all.