1725680 - Back button sometimes goes to the wrong page in Nightly

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

I had a situation where the following happened:

• start on https://news.ycombinator.com/
• click on link to: https://inews.co.uk/news/real-life/this-leeds-dad-makes-teddies-with-health-conditions-to-help-children-living-with-medical-disorders-1148392
• hit back button (returns to https://news.ycombinator.com/)
• click on link to https://news.ycombinator.com/item?id=28168933
• hit back button (returns to https://inews.co.uk/news/real-life/this-leeds-dad-makes-teddies-with-health-conditions-to-help-children-living-with-medical-disorders-1148392 instead of https://news.ycombinator.com/)

I was able to reproduce this a couple of times in a row, but can't anymore.

I believe I've noticed this kind of thing happening before, but this was the first time I was able to reproduce it to confirm it wasn't confusion on my part.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Which version of Firefox are you using, and is Fission enabled?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

93.0a1 (2021-08-12) and Fission is enabled

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This sounds like the issue jesup has seen.

I wish there was some way to reproduce.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Is there something I should check for if it happens again?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Running the script from http://mozilla.pettay.fi/moztests/shistory.log.txt in the browser console when the problematic page is in the foreground tab might reveal something.
Feel free to send the output to me, if you don't want to attach it to this bug.

The output looks something like
index: 1
requestedIndex: -1
count: 2
Entry[0], originalURI: null, uri: about:newtab, ID: 4697
Entry[1], originalURI: null, uri: http://mozilla.pettay.fi/moztests/shisto..., ID: 4833

Comment 6

[Chris Peterson [:cpeterson]]

Jeff or Randell, have you seen this Back button bug recently?

I haven't been able to repro.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

No, but I don't see it/notice it often enough to say that it's been fixed.

Comment 8

[Chris Peterson [:cpeterson]]

Olli, Randell says he still see this Back button bug "every few days". Nika says this bug is important.

I'm tentatively assigning this bug to you. If you think someone else should investigate, let me know.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

jesup, could you send the relevant session history state when you see this (see comment 5).

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Data was sent

Comment 12

[Alice0775 White]

From Bug 1731013 Comment 3. This is regressed by Bug 1697905

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1725680, requested index should be used only by the nsSHistory (and related code in CanonicalBrowsingContext), r=peterv

Using requestedIndex on the child side is hard, because there are race conditions when a session history load is triggered
and at the same time a non-session history load commits a new active entry.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0459d02e5ee5
requested index should be used only by the nsSHistory (and related code in CanonicalBrowsingContext), r=peterv

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0459d02e5ee5

Comment 16

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

This was fixed on the Latest Nightly build 132.0a1 verified on platforms: Windows 10, macOS 12 and Ubuntu 22.04 using the steps from description.

Comment 17

[Adina Petridean QA [:apetridean]]

Verified as fixed on Android as well , on the latest Nightly 132.0a1 from 05.09.2024 using Samsung Galaxy S23 Ultra (Android 14).