1725705 - [Dark mode] UI issues in the new account setup final page

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-08-13 12-27-06.png

A couple of UI issues when using dark mode with the final page in the new account setup.

• The email icon doesn't inherit the correct color.
• The calendar setup HTML dialog is not properly styled.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-08-13 12-27-15.png

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1725705-dark-mode-accountSetup.patch

I'm using the in-content variables for the dialogs to look similar to the pref dialogs.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9236263 [details] [diff] [review]
1725705-dark-mode-accountSetup.patch

Review of attachment 9236263 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thank you so much!
Please, update the commit message with:
"Bug 1725705 - [Dark mode] UI fixes for the Account Setup final page. r=aleca"

::: mail/themes/shared/mail/accountSetup.css
@@ +616,2 @@
>  }
>  

The icon should have the same blue color.
Let's add this class.
.account-type-image {
  color: var(--in-content-link-color);
}

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1725705-dark-mode-accountSetup.patch

Applied the review comments.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/860583f9d5d0
[Dark mode] UI fixes for the Account Setup final page. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9236289 [details] [diff] [review]
1725705-dark-mode-accountSetup.patch

[Approval Request Comment]
User impact if declined: with dark theme white and partly unreadable dialogs in account setup
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9236289 [details] [diff] [review]
1725705-dark-mode-accountSetup.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 92.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/82a94a469c63

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9236289 [details] [diff] [review]
1725705-dark-mode-accountSetup.patch

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/0aa5c4bdd6d5