Unable to compile js shell on macOS
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox91 unaffected, firefox92 unaffected, firefox93 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox91 | --- | unaffected |
firefox92 | --- | unaffected |
firefox93 | --- | fixed |
People
(Reporter: gkw, Assigned: glandium)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
/snip
checking for dsymutil... /usr/bin/dsymutil
checking for mkfshfs... /sbin/newfs_hfs
checking for hfs_tool... not found
checking for NSIS version... no
checking for llvm-objdump... /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/llvm-objdump
checking for zlib >= 1.2.3... no
ERROR: Package zlib was not found in the pkg-config search path.
ERROR: Perhaps you should add the directory containing `zlib.pc'
ERROR: to the PKG_CONFIG_PATH environment variable
ERROR: No package 'zlib' found
I'm now unable to compile macOS js shell using:
./configure --enable-debug --with-ccache --enable-gczeal --enable-debug-symbols --disable-bootstrap --disable-tests
Tested on m-c rev 18fc1360f9ca, macOS 11.4.
The first bad revision is:
changeset: https://hg.mozilla.org/mozilla-central/rev/6309c533e51c
user: Mike Hommey
date: Wed Aug 11 22:03:14 2021 +0000
summary: Bug 1724391 - Reset PKG_CONFIG_PATH. r=firefox-build-system-reviewers,mhentges
:glandium, please let me know what other information you need. I tried installing zlib via Homebrew and calling it via PKG_CONFIG_PATH as per the instructions but configure didn't work either.
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1724391
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Workaround: ac_add_options --without-system-zlib
.
Assignee | ||
Comment 4•3 years ago
|
||
The sysroot setup on macOS is different from Linux, and pkg-config
files, if there are, would be coming from e.g. homebrew rather than
the macOS SDK.
Assignee | ||
Comment 5•3 years ago
|
||
pkg-config is not available by default on macOS, and we might as well
avoid configure defaults that may require it.
Assignee | ||
Comment 6•3 years ago
|
||
Can you try just the first patch alone and confirm it fixes it?
Reporter | ||
Comment 7•3 years ago
|
||
What situation should we test:
- With or without zlib installed from Homebrew?
- With or without --without-system-zlib?
- With or without --disable-bootstrap? (Unsure if this matters to this bug but I'd thought to ask)
Assignee | ||
Comment 8•3 years ago
|
||
Whatever scenario was failing when you filed this bug.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/96932bb70ba1 Don't set PKG_CONFIG_* on macOS. r=firefox-build-system-reviewers,andi https://hg.mozilla.org/integration/autoland/rev/0d6bad20cf70 Don't default to system-zlib on macOS. r=firefox-build-system-reviewers,andi
Comment 10•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/96932bb70ba1
https://hg.mozilla.org/mozilla-central/rev/0d6bad20cf70
Reporter | ||
Comment 11•3 years ago
|
||
Fixed for me so far!
- Without zlib installed from Homebrew
- Without --without-system-zlib
- With --disable-bootstrap
Comment 12•3 years ago
|
||
sorry, I missed needinfo.
this solved for most case.
very edge case in bug 1726783.
Description
•