1724374 - Use --sysroot on mac builds

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1724374 - Use --sysroot on mac builds.

We're currently using -isysroot as a preprocessor flag and
-Wl,--syslibroot/-Wl,--sysroot as a linker flag, but --sysroot is
generalization of both, so we can use that instead.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1724374 - Handle the macos SDK through the same code paths as sysroots.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c32dfd8b694
Use --sysroot on mac builds. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/030e725b4799
Handle the macos SDK through the same code paths as sysroots. r=firefox-build-system-reviewers,andi

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8d4d6248454
Fix lint error in test_toolchain_configure.py a=lint-fix

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (bug 1724372, bug 1724374) for causing macos non-unified build bustages in BlockingResourceBase.h.
https://hg.mozilla.org/integration/autoland/rev/fd0d45fceab6c05f35dddc359ad71e86127950a9

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=030e725b4799d73281c210ebdbbfcc3e2515edc9&selectedTaskRun=EP4yf-6jSj-n1u8aF9zeew.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=347715493&repo=autoland&lineNumber=4645

Also, please note the lint error:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=030e725b4799d73281c210ebdbbfcc3e2515edc9&selectedTaskRun=bOCMuQbfS86CV3lCfCQWgQ.0

https://treeherder.mozilla.org/logviewer?job_id=347705795&repo=autoland&lineNumber=529

Comment 6

[Mike Hommey [:glandium]]

(In reply to Cristian Brindusan [:cbrindusan] from comment #5)

Also, please note the lint error:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=030e725b4799d73281c210ebdbbfcc3e2515edc9&selectedTaskRun=bOCMuQbfS86CV3lCfCQWgQ.0

The lint error was produced by auto-formatting on landing. Filed bug 1724605

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/759deb0a9ebb
Use --sysroot on mac builds. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/81b5d5665b4e
Handle the macos SDK through the same code paths as sysroots. r=firefox-build-system-reviewers,andi

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/759deb0a9ebb
https://hg.mozilla.org/mozilla-central/rev/81b5d5665b4e