1725873 - Reduce toolbar bookmark menu padding in compact mode

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Asif Youssuff]

The increased size of the bookmark toolbar menu (the one you can add as an icon that displays all of your bookmarks) is a common complaint about proton. I think we should use the unsupported compact mode to address this.

Comment 1

[Asif Youssuff]

Attachment: Bug 1725873 - Reduce menu panel padding in compact mode. r?mconley

Comment 2

[Asif Youssuff]

Attachment: image.png

Comment 3

[jscher2000]

Attachment: Effect on BMB drop-down of modifying padding-block from 0.5em to 2px

Suggested revision for same compactness as Firefox 78 ESR:

[uidensity=compact] menupopup > menuitem,
[uidensity=compact] menupopup > menu {
    padding-block: 2px;
}

Note: only tested on Windows.

Comment 4

[jscher2000]

Attachment: Compact menu vertical spacing comparison, Photon vs. Proton

Comment 5

[jscher2000]

Attachment: Effect on context menus of modifying padding-block from 0.5em to 2px

Comment 6

[jscher2000]

Attachment: Classic menu vertical spacing comparison, Photon vs. Proton

Comment 7

[jscher2000]

Attachment: Effect on classic menus of modifying padding-block from 0.5em to 2px

In sum, all the menus I checked look okay with this change.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/108a81c39b3d
Reduce menu panel padding in compact mode. r=dao

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/108a81c39b3d

Comment 10

[lilydjwg]

I like this change, thanks!