1725012 - Reduce arrow panel menuitem padding/margin in compact mode

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Tom S [:evilpie]]

The increased size of the bookmark menu is probably one of the most common complains about proton. I think we should use the unsupported compact mode to address this.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1725012 - Reduce arrow panel menuitem padding/margin in compact mode. r?mconley

Comment 2

[Tom S [:evilpie]]

Attachment: Screenshot

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8363b7c72148
Reduce arrow panel menuitem padding/margin in compact mode. r=desktop-theme-reviewers,dao

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8363b7c72148

Comment 5

[jscher2000]

Could this reduced vertical spacing be extended to popup panels as well, such as the Bookmarks menu that drops from the Menu Bar, and context menus? That would involve modifying the values in popup.css (at least for Windows, not sure about other platforms):

[uidensity=compact] menupopup > menuitem,
[uidensity=compact] menupopup > menu {
    padding-block: 4px;
}

Comment 6

[ross]

Why limit this option to compact mode? I'm fine with the default non-compact layout except for the fat spacing of bookmarks/right click menus. It introduces an unnecessary amount of scrolling and mousing around.

Comment 7

[Tom S [:evilpie]]

(In reply to jscher2000 from comment #5)

Could this reduced vertical spacing be extended to popup panels as well, such as the Bookmarks menu that drops from the Menu Bar, and context menus? That would involve modifying the values in popup.css (at least for Windows, not sure about other platforms):

[uidensity=compact] menupopup > menuitem,
[uidensity=compact] menupopup > menu {
    padding-block: 4px;
}

I am not sure what this really mean. (My Firefox frontend experience only really extends to poking at it with the inspector) Please open a new bug with me cc'ed, preferably with a screenshot that shows what you want to modify.

Comment 8

[Anje]

There are already plenty of bug reports with several comments see bug 1722368
all the feedback comments here:
https://mozilla.crowdicity.com/post/720482

You will find most people are particulary verbal about the bookmarks because it probably has the most menu list items and therefore irrates the most. But generic uniformity should be maintained for all menu items.
Basically, all drop down menus that were effected by the unnecessary increase in space between menu items.
Any drop down menu from the Menu Bar eg: bookmarks
Drop down menu in the menu app hamburger.
Right click drop down menus etc.

People who have the ability are currently being forced to create and use userChrome.css to work around the usability issues.
People are just irritated by the inconvenience of extra scrolling which is slowing down work throughput and with repeated use, the current design helps to increase RSI issues.

So many thanks for realising this is a serious issue and helping to fix it quickly.

Comment 9

[Anje]

The fix is extremely limited and has no effect in the Menu Bar Toolbar and other areas.
Many people do not use the Bookmark icon - one reason - it starts on a lower toolbar and therefore does not allow the same amount of view of menu items in drop down menu.

Many people use the 'Menu Bar' because that's how they learned where menu's resided.
I use it because it is more practical and a lot quicker than via the Menu app icon.
I also do not like icons - I like words because then I do not lose where I am.
Not everyone only works using icons for many reasons.

You cannot design Firefox for a Phone and expect it to work for a PC - it doesn't.
The hundreds of posts on various forums should be sufficient proof that it is not a good design idea on PC's and not appreciated.

Can the fix be applied to all areas effected?

Comment 10

[Tom S [:evilpie]]

This is not a place for discussion. Please do appreciate that this is a volunteer effort, thank you. If you have specific issues please open new bugs.